Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

walletconnect-web3-provider issues #39

Closed
digitaldonkey opened this issue Oct 10, 2018 · 1 comment
Closed

walletconnect-web3-provider issues #39

digitaldonkey opened this issue Oct 10, 2018 · 1 comment

Comments

@digitaldonkey
Copy link

I basically didn't get the code (v0.7) running as stated in readme.

  • Given rpcUrl seems to be ignored
  • The promise (or callback) from web3.eth.getAccounts() as stated in the readme is never resolved
  • There are typos in the readme code
@digitaldonkey
Copy link
Author

The provider is not defined here

walletconnect-monorepo/packages/walletconnect-web3-subprovider/src/index.js

Line 81 in fa33b75

this.provider.sendAsync(payload, function(err, response) {

pedrouid pushed a commit that referenced this issue Apr 28, 2021
@sbc64
Merge pull request #39 from WalletConnect-Labs/socket-close
8d20b50 
socket_close event
This was referenced Dec 17, 2022
Open
Open
@snyk-bot snyk-bot mentioned this issue Dec 29, 2022
Open
This was referenced Jan 10, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@digitaldonkey @pedrouid