Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe App throws errors when connecting via Web3Modal #4240

Closed
serenae-fansubs opened this issue Feb 17, 2024 · 1 comment
Closed

Safe App throws errors when connecting via Web3Modal #4240

serenae-fansubs opened this issue Feb 17, 2024 · 1 comment
Assignees
Labels
type: bug Something isn't working

Comments

@serenae-fansubs
Copy link

serenae-fansubs commented Feb 17, 2024

Describe the bug
Using Ethereum Mainnet

When connecting from (formerly named Gnosis Safe) Safe App via WalletConnect and Web3Modal, this exception always seems to occur:

Unhandled Runtime Error
Error: No matching key. session topic doesn't exist: 464e813cba28bdd9f02ac6725a91e930778fcab70931a5e758aa13008255d188

Call Stack
ds.isValidSessionTopic
node_modules/@walletconnect/sign-client/dist/index.es.js (1:30438)
ds.isValidEmit
node_modules/@walletconnect/sign-client/dist/index.es.js (1:27204)
ds.onSessionEventRequest
node_modules/@walletconnect/sign-client/dist/index.es.js (1:21682)
ds.processRequest
node_modules/@walletconnect/sign-client/dist/index.es.js (1:15394)
ds.processRequestsQueue
node_modules/@walletconnect/sign-client/dist/index.es.js (1:14756)
ds.onRelayEventRequest
node_modules/@walletconnect/sign-client/dist/index.es.js (1:14319)
EventEmitter.eval
node_modules/@walletconnect/sign-client/dist/index.es.js (1:28885)

Sometimes when connecting, I also get this additional error:

Unhandled Runtime Error
Error: Please call connect() before request()

Call Stack
lr.request
node_modules/@walletconnect/universal-provider/dist/index.es.js (27:27672)
v.request
node_modules/@walletconnect/ethereum-provider/dist/index.es.js (1:2509)
v.switchEthereumChain
node_modules/@walletconnect/ethereum-provider/dist/index.es.js (1:4941)
v.setChainId
node_modules/@walletconnect/ethereum-provider/dist/index.es.js (1:5471)
EventEmitter.eval
node_modules/@walletconnect/ethereum-provider/dist/index.es.js (1:4078)
EventEmitter.emit
node_modules/events/events.js (153:0)
EventEmitter.eval
node_modules/@walletconnect/universal-provider/dist/index.es.js (27:32454)
EventEmitter.emit
node_modules/events/events.js (153:0)
ds.onSessionEventRequest
node_modules/@walletconnect/sign-client/dist/index.es.js (1:21710)
ds.processRequest
node_modules/@walletconnect/sign-client/dist/index.es.js (1:15394)
ds.processRequestsQueue
node_modules/@walletconnect/sign-client/dist/index.es.js (1:14756)
ds.onRelayEventRequest
node_modules/@walletconnect/sign-client/dist/index.es.js (1:14319)
EventEmitter.eval
node_modules/@walletconnect/sign-client/dist/index.es.js (1:28885)

SDK Version (if relevant)

To Reproduce
Steps to reproduce the behavior:

  1. Go to either https://web3modal.com/ or https://lab.web3modal.com/library/wagmi/
  2. Click on Connect Wallet
  3. Choose WalletConnect, and copy link
  4. In the Safe App, click on WalletConnect and paste the link, then approve the connection
  5. Back on the Web3Modal page, the wallet appears to connect, but you will see these errors in the browser console:

image

image

Expected behavior
The "no matching key" and "please call connect before request" errors should not be seen in the browser console.

Screenshots
When running a react app in dev mode, you can see the errors pop up right there on the page:
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Tried Brave, Edge, and Firefox
  • Version: All latest versions

Additional context
rainbow-me/rainbowkit#1772

@serenae-fansubs serenae-fansubs added the type: bug Something isn't working label Feb 17, 2024
@glitch-txs glitch-txs self-assigned this Feb 17, 2024
@glitch-txs
Copy link
Member

I'm not able to repro on https://lab.web3modal.com/library/wagmi/

could you check again? if this persists I think it would be better to open the issue in the Safe repository.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants