-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polling Timeout not handled #45
Comments
Good point! Going to add that really quick to handle the timeout better.
Regarding this last comment, is currently fixed, update to the lastest version |
I've looked at these issues and they are working. Timeout's are catched when Error is thrown and timeout arguments are passed |
Fix JS typo in Standalone Dapp Page
If you start listening for confirmation via QR code after some while the session times out and walletConnect stops polling the bridge server.
in my current approach I wrap that in a try catch block and provide a retry button.
https://github.com/digitaldonkey/web3ready/blob/7623a475ebbdb2c7f89e866876f6e4b9ef0c3244/src/components/signerDialogs/WalletConnect.vue#L104-L116
You might want to handle that in the QR code app too.
It would also be great to override the timeout settings in listenSessionStatus(POLL_INTERVAL, TIMEOUT).
The text was updated successfully, but these errors were encountered: