Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polling Timeout not handled #45

Closed
digitaldonkey opened this issue Nov 23, 2018 · 2 comments
Closed

Polling Timeout not handled #45

digitaldonkey opened this issue Nov 23, 2018 · 2 comments

Comments

@digitaldonkey
Copy link

If you start listening for confirmation via QR code after some while the session times out and walletConnect stops polling the bridge server.

in my current approach I wrap that in a try catch block and provide a retry button.

https://github.com/digitaldonkey/web3ready/blob/7623a475ebbdb2c7f89e866876f6e4b9ef0c3244/src/components/signerDialogs/WalletConnect.vue#L104-L116

You might want to handle that in the QR code app too.

It would also be great to override the timeout settings in listenSessionStatus(POLL_INTERVAL, TIMEOUT).

@pedrouid
Copy link
Member

If you start listening for confirmation via QR code after some while the session times out and walletConnect stops polling the bridge server. in my current approach I wrap that in a try catch block and provide a retry button.

Good point! Going to add that really quick to handle the timeout better.

It would also be great to override the timeout settings in listenSessionStatus(POLL_INTERVAL, TIMEOUT)

Regarding this last comment, is currently fixed, update to the lastest version

@pedrouid
Copy link
Member

I've looked at these issues and they are working. Timeout's are catched when Error is thrown and timeout arguments are passed

LeeAlephium pushed a commit to alephium/walletconnect-monorepo that referenced this issue May 24, 2022
Fix JS typo in Standalone Dapp Page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants