Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web3-subprovider not shipping types #98

Closed
NoahZinsmeister opened this issue Apr 7, 2019 · 2 comments
Closed

web3-subprovider not shipping types #98

NoahZinsmeister opened this issue Apr 7, 2019 · 2 comments

Comments

@NoahZinsmeister
Copy link
Contributor

yarn add @walletconnect/web3-subprovider, which currently installs ^1.0.0-beta.10, does not ship types.

Screen Shot 2019-04-07 at 1 08 56 PM
@pedrouid
Copy link
Member

Current configuration uses ts-loader to ship types but since web3-provider and web3-subprovider are javascript files, it's not able to ship types. We either refactor these two packages into typescript or write the typings manually.

@pedrouid
Copy link
Member

Probably going to deprecate soon web3-provider and web3-subprovider in favor of eth-provider which doesn't have web3-provider-engine dependency, it's EIP-1193 complaint and all written in Typescript so types will be included

LeeAlephium pushed a commit to alephium/walletconnect-monorepo that referenced this issue May 24, 2022
@jakubuid @chadyj
Update Kotlin documentation (WalletConnect#98)
523f932 
* Update Kotlin documentation

* remove break tags

These cause a SyntaxError "Unterminated JSX contents"

* syntax highlighting

Co-authored-by: Chad <chadyj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NoahZinsmeister @pedrouid