Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit2 support on Wallet Connect? #1451

Closed
ronaldoguedess opened this issue Jul 17, 2024 · 2 comments
Closed

Permit2 support on Wallet Connect? #1451

ronaldoguedess opened this issue Jul 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ronaldoguedess
Copy link

ronaldoguedess commented Jul 17, 2024

I checked, and I couldn't find the Permit2 function to allow Approve off-chain.
Is it unavailable for Wallet Connect? It would be great add this feature on the testing dapp.
https://react-app.walletconnect.com/

Which one should I use to achieve what I want? eth_signTypedData ?

eth_sendTransaction,
personal_sign,
eth_accounts,
eth_requestAccounts,
eth_sendRawTransaction,
eth_sign,
eth_signTransaction,
eth_signTypedData,
eth_signTypedData_v3,
eth_signTypedData_v4;
@ronaldoguedess ronaldoguedess added the enhancement New feature or request label Jul 17, 2024
@xemniz
Copy link

xemniz commented Jul 30, 2024

any updates?

@ronaldoguedess
Copy link
Author

ronaldoguedess commented Jul 30, 2024

I realized that Permit is not a Ethereum function, but a method that you can obtain inside eth_signTypedData_v4. When the dapp sends this, make sure to check if the PrimaryType is Permit.

The problem is that i didn't found any dapp that works with Permit2, just Permit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants