New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TREZOR One firmware support for 1.10.1 #530
Comments
Oh thanks for letting me know - need to check out the new firmware and yea - most likely I just need to adjust the check |
I see you updated the version check, but not the error message. Happens to me all the time 😄 . Would it be a bad idea to allow future versions as well? Does Trezor have compatibility guarantees for the USB interface? |
Yea - was also thinking about that. Got a lot of bad reviews on Google Play because of outdated versions. But I am not sure about just allowing future versions - it could just break in a worse/undefined way there and AFAIK TREZOR has no guarantees here. A protocol version would really be nice. cc @prusnak |
We never break the protocol intentionally. |
Interesting - not even with a major version? So I can just assume that when it works with one version it will also work with all following versions? Bit scared - but maybe I just remove the check then - or just check for the major version and accept all minor/patch versions then. |
Yes, just keep the minimum version check (i.e. 1.8.0 and older / 2.1.0 and older). |
Thanks for the insight - will keep the minimum then and also the major check I guess - but drop the minor check. And If you ever break compatibility for the minor version: I know where you work ;-) |
Haha :D |
I'm not sure if this is simply a matter of adjusting the firmware version check or if there are actual changes that make WallETH incompatible with the latest firmware revisions, but it is currently impossible to add a TREZOR address from a TREZOR One with the latest firmware. The error message is "For Trezor model ONE only Firmware 1.8.X or 1.9.X is supported but found 1.10.1".
The text was updated successfully, but these errors were encountered: