Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TREZOR One firmware support for 1.10.1 #530

Closed
GuizzyQC opened this issue Jun 29, 2021 · 8 comments
Closed

TREZOR One firmware support for 1.10.1 #530

GuizzyQC opened this issue Jun 29, 2021 · 8 comments

Comments

@GuizzyQC
Copy link

I'm not sure if this is simply a matter of adjusting the firmware version check or if there are actual changes that make WallETH incompatible with the latest firmware revisions, but it is currently impossible to add a TREZOR address from a TREZOR One with the latest firmware. The error message is "For Trezor model ONE only Firmware 1.8.X or 1.9.X is supported but found 1.10.1".

@ligi
Copy link
Member

ligi commented Jun 29, 2021

Oh thanks for letting me know - need to check out the new firmware and yea - most likely I just need to adjust the check

ligi added a commit that referenced this issue Jul 2, 2021
@exzombie
Copy link

exzombie commented Jul 3, 2021

I see you updated the version check, but not the error message. Happens to me all the time 😄 . Would it be a bad idea to allow future versions as well? Does Trezor have compatibility guarantees for the USB interface?

@ligi
Copy link
Member

ligi commented Jul 3, 2021

Yea - was also thinking about that. Got a lot of bad reviews on Google Play because of outdated versions. But I am not sure about just allowing future versions - it could just break in a worse/undefined way there and AFAIK TREZOR has no guarantees here. A protocol version would really be nice.

cc @prusnak

@prusnak
Copy link

prusnak commented Jul 3, 2021

We never break the protocol intentionally.

@ligi
Copy link
Member

ligi commented Jul 3, 2021

Interesting - not even with a major version? So I can just assume that when it works with one version it will also work with all following versions? Bit scared - but maybe I just remove the check then - or just check for the major version and accept all minor/patch versions then.

@prusnak
Copy link

prusnak commented Jul 3, 2021

Yes, just keep the minimum version check (i.e. 1.8.0 and older / 2.1.0 and older).

@ligi
Copy link
Member

ligi commented Jul 3, 2021

Thanks for the insight - will keep the minimum then and also the major check I guess - but drop the minor check. And If you ever break compatibility for the minor version: I know where you work ;-)

@prusnak
Copy link

prusnak commented Jul 3, 2021

Haha :D

@ligi ligi closed this as completed in 31e016f Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants