New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for days #68
Conversation
@kerro Firstly thank you so much for taking the time to build this out! It's a very important feature and has been a while since it s pending and no one (including me) had taken a stab at it. Secondly I think you ve directly edited the transpiled Lemme know your thoughts and thanks again for taking up this long-awaited feature for development! |
I already did it like you said using webpack. |
Terribly silly of me I ll go through these changes and play with it a bit and get back later today with comments. |
@@ -262,6 +262,7 @@ | |||
PLUGIN_NAME: 'timer', | |||
TIMER_RUNNING: 'running', | |||
TIMER_PAUSED: 'paused', | |||
DAYINSECOND: 86400, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename this to DAYINSECONDS
I ve reviewed this PR and suggested some minor improvements. Aside from that this looks great. Once you update this PR with the suggested changes, I ll merge it right in. May I also ask you to please bump the version to |
I updated files in dist directory ;-) |
Looks great 👍 thank you very much @kerro ! |
Feature #15