Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

你的timer.jquery插件有个问题...Your timer.jquery js have a bug... #70

Closed
huangxinliu opened this issue Jun 16, 2016 · 3 comments

Comments

@huangxinliu
Copy link

您好,首先我很抱歉不太会讲英语,我在项目中使用你的timer.jquery,发现有个问题,在手机下不支持"Object.assign",我把它换成"$.extend"就好了。
HI,First I'm sorry I don't speak English,I use your timer.jquery for my project, In the mobile browser not support "Object.assign", Me replace "$.extend" it's ok.

@walmik
Copy link
Owner

walmik commented Jun 16, 2016

Thank you very much @huangxinliu !
I ve updated the plugin to use $.extend. Please do let me know if you still see this issue on mobile.

@huangxinliu
Copy link
Author

@walmik still have Object.assign on timer.jquery/dist/timer.jquery.js 158 line, 0.0

@walmik
Copy link
Owner

walmik commented Jun 17, 2016

@huangxinliu You are right, there was yet another Object.assign in the src itself. I ve removed it now. Can you please verify one last time? Thanks again for your diligence!

@walmik walmik closed this as completed Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants