Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store total supply along market fee #124

Open
oberstet opened this issue May 17, 2020 · 0 comments
Open

Store total supply along market fee #124

oberstet opened this issue May 17, 2020 · 0 comments
Assignees

Comments

@oberstet
Copy link
Member

When a new market is created, the market owner will set the fee rate that applies within the market using an absolute token amount that is to be related to the total token supply at that moment!

However, for tokens with a non-fixed supply, the total supply can change. Hence we should store total supply as well, here https://github.com/crossbario/xbr-protocol/blob/2398f2a03f56fb3dd27be1a48fbd2d93ba9be347/contracts/XBRTypes.sol#L117

@oberstet oberstet added this to the Release v20.9.1 milestone Aug 26, 2020
@oberstet oberstet self-assigned this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant