Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI-611] Summary fix #1709

Merged
merged 10 commits into from Jan 25, 2021
Merged

[CLI-611] Summary fix #1709

merged 10 commits into from Jan 25, 2021

Conversation

farizrahman4u
Copy link
Contributor

@farizrahman4u farizrahman4u commented Jan 15, 2021

@farizrahman4u farizrahman4u changed the title Summary fix [CLI-611] Summary fix Jan 15, 2021
@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

Merging #1709 (e1184cc) into master (49c6ba6) will increase coverage by 0.10%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1709      +/-   ##
==========================================
+ Coverage   69.20%   69.31%   +0.10%     
==========================================
  Files         220      221       +1     
  Lines       25620    25635      +15     
==========================================
+ Hits        17730    17768      +38     
+ Misses       7890     7867      -23     
Impacted Files Coverage Δ
wandb/apis/internal.py 87.69% <50.00%> (-1.20%) ⬇️
tests/test_summary.py 100.00% <100.00%> (ø)
wandb/old/summary.py 53.96% <100.00%> (+9.21%) ⬆️
wandb/sdk/wandb_settings.py 91.00% <0.00%> (-0.36%) ⬇️
wandb/sdk/lib/git.py 72.18% <0.00%> (ø)
wandb/sdk/internal/meta.py 85.90% <0.00%> (+3.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c6ba6...e1184cc. Read the comment docs.

Copy link
Contributor

@vanpelt vanpelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused on what's happening

@raubitsj raubitsj merged commit c5b130d into master Jan 25, 2021
@farizrahman4u farizrahman4u deleted the fr_summary_fix branch January 26, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempting to access summary that is numpy array fails with 'Api' object has no attribute 'download_url'
3 participants