Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop a python2 backport deps (enum34, subprocess32, configparser) #3004

Merged
merged 6 commits into from Jan 14, 2022
Merged

Drop a python2 backport deps (enum34, subprocess32, configparser) #3004

merged 6 commits into from Jan 14, 2022

Conversation

jbylund
Copy link
Contributor

@jbylund jbylund commented Dec 8, 2021

Fixes #2992

Description

Removes a few backported libs that were necessary to support python 2.7 (and maybe 3.5-).

Testing

Ran tox, but worried that this is exactly the type of stuff that's likely to have limited coverage.

@raubitsj
Copy link
Member

raubitsj commented Dec 8, 2021

Great!
We have been planning on doing this, thanks for doing this.
I wasnt sure if configparser was an exact backport of what is in python3.6+

Also you can drop tying also since the package doesnt support python3.5 any more

@jbylund
Copy link
Contributor Author

jbylund commented Dec 8, 2021

I wasnt sure if configparser was an exact backport of what is in python3.6+

Based on the readme, it appears that wand has been using the stdlib version of configparser since it wasn't doing from backports ....

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #3004 (3d519da) into master (4b640ec) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3004      +/-   ##
==========================================
+ Coverage   79.03%   79.05%   +0.01%     
==========================================
  Files         210      210              
  Lines       27640    27636       -4     
==========================================
+ Hits        21846    21847       +1     
+ Misses       5794     5789       -5     
Flag Coverage Δ
functest 57.05% <100.00%> (+0.05%) ⬆️
unittest 68.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/internal/internal_api.py 83.69% <100.00%> (+0.09%) ⬆️
wandb/sdk/internal/meta.py 90.68% <100.00%> (+3.56%) ⬆️
wandb/filesync/step_prepare.py 92.85% <0.00%> (-1.43%) ⬇️
wandb/sdk/internal/stats.py 67.22% <0.00%> (-0.56%) ⬇️
wandb/sdk/lib/git.py 76.35% <0.00%> (ø)

@dmitryduev dmitryduev self-requested a review January 14, 2022 18:26
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Will merge once the CI is green.

@dmitryduev dmitryduev merged commit 77f0967 into wandb:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Q] Drop dependency on backported configparser?
4 participants