U/fjammes/dm 750 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loy.py, in order install procedure become eups-compliant: - MySQL options management in scisql-deploy.py - scisql-deploy.py is installed in bin directory
- creation of deployment configuration (MySQL credential, sciSQL prefix,
vsuffix and version)
- use of templating system to create temporary deployment files/script
- removal of substitute.py - management of MySQL client binary, plugin directory and credentials removed from waf build script
| Defaults to ${PREFIX}.''') | ||
| ctx.add_option('--mysql-config', type='string', dest='mysql_config', | ||
| help='''Path to the mysql_config script (e.g. /usr/local/bin/mysql_config). | ||
| Used to obtain the location of MySQL header files and plugins.''') |
There was a problem hiding this comment.
Is it still used to get the location of plugins?
| logging.fatal('Invalid MySQL socket. Use --mysql-socket options.' | ||
| .format(args.mysql_socket) | ||
| ) | ||
| exit(1) |
|
Overall, I think this looks OK, and I'm happy that you managed to keep all the testing intact. I trust that you tested everything, so I didn't actually try out this code myself (but let me know if you'd like me to). Thanks for getting this done on such short notice! |
fjammes
force-pushed
the
u/fjammes/DM-750
branch
from
92f2c44
to
0555747
Compare
- Better isolation of shared library and client builds in waf script
fjammes
force-pushed
the
u/fjammes/DM-750
branch
from
deb7632
to
483fa5f
Compare
- more robust client mode - undeployment of plugin
- moving run_command() from configure module to scisql-deploy.py - improving indentation - BUGFIX : replacing exit() with sys.exit()
fjammes
force-pushed
the
u/fjammes/DM-750
branch
from
483fa5f
to
f712a1c
Compare
- Adding python module named 'utils'
wangd
added a commit
that referenced
this pull request
Oct 1, 2014
Merging U/fjammes/dm-750 from fjammes, reviewed by smonkewitz
|
Thanks :-) On 01/10/2014 20:59, Daniel L. Wang wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Serge,
Code is finished, but I still need to write documentation. (I may also had colored log if I've enough time.)
In order to test, you can use and update test/test-install-process.sh.
Thanks,
Fabrice