Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark C bindings as unsafe or don't make them public #1

Open
ammaraskar opened this issue Feb 25, 2021 · 0 comments · May be fixed by #2
Open

Mark C bindings as unsafe or don't make them public #1

ammaraskar opened this issue Feb 25, 2021 · 0 comments · May be fixed by #2

Comments

@ammaraskar
Copy link

Hi there, we (Rust group @sslab-gatech) are scanning crates on crates.io for potential soundness bugs. We noticed that the bayer::ffi module contains functions intended to serve as C bindings:

https://github.com/wangds/libbayer/blob/master/src/ffi.rs

However, these should probably be marked as unsafe or not be exposed publicly in the crate, otherwise it allows users to potentially cause memory safety issues from safe Rust by passing wrong raw pointers to the ffi functions.

@virtualritz virtualritz linked a pull request Jan 31, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant