New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HttpRequest Extensions #1
Labels
Milestone
Comments
static class and constructor has issue with dependency injection. |
Supeb, |
wangkanai
added a commit
that referenced
this issue
Nov 15, 2018
I have found a for this to work now. |
The usage has got simpler than what is expected. var browser = Request.Browser();
var platform = Request.Platform();
var device = Request.Device();
var engine = Request.Engine(); Example of usage public IActionResult Index()
{
ViewData["Device"] = Request.Device().Type;
return View(_resolver);
} |
wangkanai
added a commit
that referenced
this issue
Nov 15, 2018
Calling community, please add test units |
@wangkanai do you still need help with unittests? |
@vovikdrg yap 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Adding extensible to existing usage scenario is a key design. So I would like to propose a concept of extending the
HttpRequest
for developer to access theBrowser
,Device
,Platform
,Engine
directly. This extension then retrieve the instance from theBrowserService
.I would like to hear the community regarding this concept.
The text was updated successfully, but these errors were encountered: