Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samsung Galaxy S24 Ultra #1007

Open
wangkanai opened this issue May 11, 2024 · 3 comments
Open

Samsung Galaxy S24 Ultra #1007

wangkanai opened this issue May 11, 2024 · 3 comments
Milestone

Comments

@wangkanai
Copy link
Owner

wangkanai commented May 11, 2024

@wangkanai thanks for a quick fix, works as expected now. There is another thing which I don't remember to work properly - android version is always 0.0

This is the user agent from Samsung Galaxy S24 Ultra with android 14 but in my logs I see a bunch of customers having the same UA.
Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Mobile Safari/537.36

Reading this article I see that google does it intentionally and moved useful information into user agent client hints since 2022... Is it possible to fix it as well? Thanks
https://mobiforge.com/research-analysis/the-mysterious-model-k

Originally posted by @slava-se in #960 (comment)

@wangkanai
Copy link
Owner Author

@slava-se You are saying that the version of the Browser is not correct, right?

@wangkanai wangkanai added this to the 8.0 milestone May 11, 2024
@slava-se
Copy link

@wangkanai sorry, I mean the IPlatformService.Version.
It is detected as 0.0 for chrome on android and it is not limited to Galaxy S24 Ultra, it seems that all devices with Chrome for Android are affected since at least 3 versions.
So from what I see in the logs, the same UA is used since Android Chrome 122 regardless of which android device you use:
Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Mobile Safari/537.36

P.S. I think we have the same problem with Windows 11 as it's detected as Windows 10 now because the correct information is contained in "user agent client hints" now as well.
This is what I get from my windows 11 + chrome:
UA:Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36

So the general title should probably be "Consider user agent client hints" but I'm not sure if it's possible on backend at all as not even every browser has implemented them and/or maybe some additional headers must be added to the server configuration.

@wangkanai
Copy link
Owner Author

P.S. I think we have the same problem with Windows 11 as it's detected as Windows 10 now because the correct information is contained in "user agent client hints" now as well. This is what I get from my windows 11 + chrome: UA:Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36

For Windows 11 and Windows, issues run much deeper than just using user-agent now. It is referenced in issue #955 Add support for detecting Windows 11. I am planning to do a rewrite of the Detection in version 9.0, so make sure that Detection has more tools to identify devices than just the user-agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants