New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

代码优化建议 #8

Open

IUyuRtBbyQnRCI opened this issue Jul 12, 2018 · 0 comments

IUyuRtBbyQnRCI commented Jul 12, 2018

帮您省几行代码

WRProxy.swift
if pageControl.isHidden == false // line 58  if !pageControl.isHidden
let animated = (isEndlessScroll == true) ? false : true  //let animated = isEndlessScroll != true

改进

WRProxy.swift
使用 `Proxy + (Proxy + Extension`) 不如使用 `class` 或 `struct`,给每一个设置属性赋一个默认值
建议参考 `https://github.com/xumaohuai/SBCycleScrollView`

希望该框架可以用到更多的企业级项目中去！💪💪💪

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment