Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of Hard-coded Cryptographic Key vulnerability. #60

Closed
manunio opened this issue Jul 4, 2022 · 1 comment
Closed

Use of Hard-coded Cryptographic Key vulnerability. #60

manunio opened this issue Jul 4, 2022 · 1 comment

Comments

@manunio
Copy link
Contributor

manunio commented Jul 4, 2022

Hi mall-cook/packages/mall-cook-service uses hardcoded jwt secret to sign and decode jwt tokens, which makes it vulnerable to forging token and impersonate as a valid user and it also uses jwt.decode() instead of jwt.verify() function to decode tokens, which does not validate token signature while decoding token, which also may result in token forging by attackers.

pull request with fix for above mentioned vulnerabilities #59

see https://r2c.dev/blog/2020/hardcoded-secrets-unverified-tokens-and-other-common-jwt-mistakes/ for more details

jwt-hardcoded-key

@wangyuan389
Copy link
Owner

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants