Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some improvements for checkplotserver #9

Open
22 of 37 tasks
waqasbhatti opened this issue Jan 24, 2017 · 4 comments
Open
22 of 37 tasks

some improvements for checkplotserver #9

waqasbhatti opened this issue Jan 24, 2017 · 4 comments
Assignees

Comments

@waqasbhatti
Copy link
Owner

waqasbhatti commented Jan 24, 2017

Older stuff:

  • add sync back to checkplot-filelist.json
  • add load of already reviewed objects from checkplot-filelist.json
  • fix annoying behavior with moving to phased light curve tile if selected, this needs to check if the current tile is in view and if it is, don't move the viewport
  • add controls for redoing each type of period-finding
  • add controls for picking peaks in the periodograms to plot phased light curves for
  • add controls for calculation of variable star features (from varbase)
  • add controls for doing whitening of periodograms and masking periodic signals
  • fix bugs with periods/epochs obtained from tabs other than the first one not being registered
  • add in the ACF and AoVHM period-finders to the period-finding tab
  • enforce the new readonly rules with no tools available
  • add the fancy new neighbor stuff now in checkplot_pickles to a new neighbors tab
  • actually document the neighbor stuff in checkplot.py

High priority (ordered by increasing complexity):

  • readonly mode should disable all the textboxes and also the phased LC tile selection
  • export to PNG should not work in readonly mode?
  • put the neighbor color and mag diff info into the neighbor display
  • checkplots should use GAIA proper motions if the provided LC objectinfo doesn't have any
  • add ability to download exported checkplot PNG directly from server instead of just pointing to the file on the server (this might be as simple as returning a base64 PNG after the POST to /cp/tools that triggers the PNG export action, then turning this PNG into a downloadable file using the same trick as for the exported list CSV/JSON)
  • fix the annoying saving forever animation that happens at the end of a checkplot list traverse
  • check if the finder chart reticle is correctly done
  • clean up exported CSV to remove empty columns
  • add a cp2png script to convert directories/lists of checkplot pickles to PNGs (useful after they've all been reviewed)
  • add ability to flag objects for further review, add stuff in sidebar for this, special notation in the checkplot JSON as well as the output CSV/JSON of reviewed objects
  • add a place on the overview tab somewhere for extra object information that'd go into a checkplot pickle's 'extrainfo' key as a dict (standardize this format)
  • actually enable saving all changes in temp checkplots back to original checkplot and loading from temp checkplots all the results from run period-finders and LC tools
  • add in the 'finalized' checkplot functionality
  • add some sort of object comment and metadata history thing to checkplot pickles
  • turn the periodogram plot in the period-search tab into a canvas and enable clicking on any point to set the peak to plot a phased LC for
  • implement downloadable filtered times, mags, errs as CSV that take into account the currently active LC filters on the period-search tab
  • implement LC collection overview as a pullout tab or something; this will put the finder chart and (now interactive) overlay from make_lclist into the UI; this would involving giving checkplotlist a --lclist kwarg or something to point to the generated LC list, which the checkplotserver would pick up and use to find and load the finder base plot and xy positions of the objects in the LC collection (we should then store the finder as base64 inside the lclist pickle)
  • for the GAIA neighbors, get their proper motion ra/decl vectors from the backend if available, add checkboxes to the GAIA neighbors table, and for each checked object, add an overlay box for it and a proper motion vector to the finder. This will make it easier to see if neighbors are perhaps proper motion companions.

Later (ordered by increasing complexity):

  • add a object/variability tag cloud to the sidebar reviewed objects list
  • add back trapezoid and invgauss EB fit to the lcfit tab
  • add back starfeatures and periodicfeatures to the variability tab
  • add some sort of zoomed viewer for navigating phased LC tiles (this might be a carousel?)
  • think about moving all tools into one tab panel so we don't need to duplicate phased LC displays on every panel
  • add queuing and locking to saving and loading checkplots, with appropriate UI progress notification, so multiple people can work on a checkplot project using the same server
  • update CSS to Bootstrap v4 final
@waqasbhatti
Copy link
Owner Author

waqasbhatti commented Jan 27, 2017

Some more improvements for later:

  • add ability to flag objects for further review, add stuff in sidebar for this, special notation in the checkplot JSON as well as the output CSV/JSON of reviewed objects
  • add controls for calculation of variable star features (from varbase)
  • add controls for doing whitening of periodograms and masking periodic signals

@lgbouma
Copy link
Contributor

lgbouma commented Feb 17, 2017

Further improvements:

  • modify interface to use screen space more efficiently when leafing through LCs. (e.g., to try and fit periodograms, phase LCs, and unphased LCs by detecting screen size). In below screen, moving between upper and lower pictures requires scrolling. (N.b. this might be avoidable by just taking a monitor and rotating it, physically, by 90 degrees).

pic0
pic1

@waqasbhatti waqasbhatti added this to the v0.2 milestone Apr 5, 2017
@waqasbhatti
Copy link
Owner Author

waqasbhatti commented Oct 19, 2017

  • fix bugs with periods/epochs obtained from tabs other than the first one not being registered
  • actually enable saving all changes back to original checkplot
  • add the fancy new neighbor stuff now in checkplot_pickles to a new neighbors tab. this will have LCs, objectids, and coordinates
  • actually document the neighbor stuff in checkplot.py
  • add the 'between' operators to checkplotlist --filter
  • add in the ACF and AoVHM period-finders to the period-finding tab
  • add in trapezoid fit to the lcfit tab

@waqasbhatti
Copy link
Owner Author

Reminder to self to update checkplotserver CSS to bootstrap v4 final, now that it's finally done.

@waqasbhatti waqasbhatti removed this from the v0.2 milestone Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants