Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Subscribe button not disabled when logged out #21

Closed
duoi opened this issue Apr 1, 2024 · 1 comment
Closed

Bug: Subscribe button not disabled when logged out #21

duoi opened this issue Apr 1, 2024 · 1 comment

Comments

@duoi
Copy link

duoi commented Apr 1, 2024

Hello,

Issue: Currently the subscribe button is not disabled when a user is logged out.

Impact: It's still possible to click the button, but it doesn't do anything or give any feedback.

Proposed solution:

  1. Introduce isLoggedIn or similar to determine login state.
import { auth } from '../../store';
let isLoggedIn = false;
auth.subscribe((value) => {
    isLoggedIn = value !== null;
});
  1. Apply this to both the subscribe and the add to playlist buttons (which currently just check for personalPlaylists being undefined).
  2. Add login required tooltip when the disabled state is active
@WardPearce
Copy link
Collaborator

Fixed via #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants