Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autobuild and make manual overlay building more efficient #1018

Open
1 task done
anderbubble opened this issue Dec 14, 2023 · 0 comments
Open
1 task done

Remove autobuild and make manual overlay building more efficient #1018

anderbubble opened this issue Dec 14, 2023 · 0 comments
Labels
discuss A topic for discussion in a community meeting enhancement New feature or request overlay Pertaining to the included Warewulf overlays
Milestone

Comments

@anderbubble
Copy link
Collaborator

Summary

Remove autobuild from Warewulf and replace it with multi-threaded overlay building.

Rationale

griznog
autobuild = true doesn't catch every possible corner case that needs to rebuild the overlays, it'll save headaches long term to just get in the habit of rebuilding them after any change you make.


anderbubble
My new year’s resolution: make autobuild good enough that @griznog can stop saying this.

griznog
I don't think it's possible. How is it going to detect when I manually edit a file? Or when I manually edit nodes.conf. I think it's a dead-end, the only possible solution I can see that would work is if the build is triggered on every request for an overlay when made to warewulfd , which ends up being thundering herd bait.


anderbubble
Maybe we should just get rid of autobuild so it stops being a point of confusion, then.

griznog
I'd vote that effort that would have been spent on autobuild would be better off put toward making wwctl overlay build multi-threaded so it completes faster.

Description

Warewulf tries to, in some circumstances, automatically build overlays when it understands doing so to be necessary. But this leads to a reasonable assumption in our user community that overlay builds will always happen automatically when necessary. This is often not the case, and leads to confusion.

In stead, we should remove autobuild and document overlay building more thoroughly. We should then enhance overlay building by multi-threading it, such that each overlay for each node is built in its own thread. (e.g., n1/system, n1/runtime, n2/system, n2/runtime is 4 threads)

Additional information

No response

General information

  • I have searched the issues of this repo and believe this is not a duplicate
@anderbubble anderbubble added enhancement New feature or request discuss A topic for discussion in a community meeting labels Dec 14, 2023
@anderbubble anderbubble added this to the 4.6.0 milestone Dec 14, 2023
@anderbubble anderbubble added the overlay Pertaining to the included Warewulf overlays label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss A topic for discussion in a community meeting enhancement New feature or request overlay Pertaining to the included Warewulf overlays
Projects
None yet
Development

No branches or pull requests

1 participant