Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CIDR format to warewulf.conf parse #1150

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

JasonYangShadow
Copy link
Member

Description of the Pull Request (PR):

when parsing warewulf.conf, CIDR format will cause issue.

This fixes or addresses the following GitHub issues:

Before submitting a PR, make sure you have done the following:

@JasonYangShadow JasonYangShadow marked this pull request as ready for review March 22, 2024 04:35
internal/pkg/config/root.go Outdated Show resolved Hide resolved
Signed-off-by: Xu Yang <xyang@ciq.com>
@anderbubble anderbubble added the bug Something isn't working label Jun 1, 2024
Copy link
Collaborator

@anderbubble anderbubble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with local testing.

@anderbubble anderbubble merged commit 36a5083 into warewulf:main Jun 1, 2024
17 checks passed
anderbubble added a commit that referenced this pull request Jun 1, 2024
add CIDR format to warewulf.conf parse

(cherry picked from commit 36a5083)

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
@anderbubble
Copy link
Collaborator

Backported to v4.5.x for v4.5.3.

@anderbubble anderbubble added the backported:4.5.x backported to 4.5.x label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported:4.5.x backported to 4.5.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wwclient doesn't support CIDR format for warewulf server
2 participants