Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit all Warewulf logs for consistency and typos #1203

Open
anderbubble opened this issue Apr 23, 2024 · 0 comments
Open

audit all Warewulf logs for consistency and typos #1203

anderbubble opened this issue Apr 23, 2024 · 0 comments
Assignees
@anderbubble
Labels
needs refinement refactor
Milestone
v4.6.0

Comments

@anderbubble
Copy link
Collaborator

anderbubble commented Apr 23, 2024 •
edited

I also want to simplify instances like wwlog.Error(fmt.Sprintf("%v", err.Error())) since wwlog.Error (and its peers) already call fmt.Sprintf.

warewulf/internal/pkg/wwlog/wwlog.go

Line 104 in ad2992c

message := fmt.Sprintf(rec.Msg, rec.Args...)

@anderbubble anderbubble added this to the v4.6.0 milestone Apr 23, 2024
@anderbubble anderbubble self-assigned this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anderbubble anderbubble

Labels
needs refinement refactor
Projects
None yet
Milestone
v4.6.0
Development

No branches or pull requests
1 participant
@anderbubble