Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old container images action fails on fork repository #125

Closed
mugdha-adhav opened this issue Jan 21, 2024 · 5 comments · Fixed by #126
Closed

Delete old container images action fails on fork repository #125

mugdha-adhav opened this issue Jan 21, 2024 · 5 comments · Fixed by #126
Labels
good-first-issue Good for newcomers help-wanted Extra attention is needed

Comments

@mugdha-adhav
Copy link
Collaborator

This is the failure I noticed on my fork.

@mugdha-adhav mugdha-adhav added good-first-issue Good for newcomers help-wanted Extra attention is needed labels Jan 21, 2024
@HarjobandeepSingh
Copy link

Ensure that the package-name and package-type in your workflow file match exactly with the package you’re trying to delete.

@mbtamuli
Copy link
Contributor

mbtamuli commented Jan 21, 2024

@mugdha-adhav
Copy link
Collaborator Author

I think the issue is that https://github.com/warm-metal/csi-driver-image/blob/a2e26ec4c89837d672e8e638eab5c39eb056df0f/.github/workflows/images-build-and-push.yaml this workflow needs additional permissions

permissions:
  packages: write

If the issue is with the permissions lacking in the workflow, I wonder how did the cleanup run successfully on another fork.

@mugdha-adhav
Copy link
Collaborator Author

Ensure that the package-name and package-type in your workflow file match exactly with the package you’re trying to delete.

@HarjobandeepSingh it is using the same name already.

@mbtamuli
Copy link
Contributor

mbtamuli commented Jan 21, 2024

See this comment - #117 (comment)

@mugdha-adhav Please see this action run https://github.com/warm-metal/csi-driver-image/actions/runs/7602485716/job/20703096374.

The package was created successfully and automatically made public - https://github.com/warm-metal/csi-driver-image/pkgs/container/csi-driver-image%2Fdevcontainer

I'm positive just adding that permissions should do away with the error in a fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers help-wanted Extra attention is needed
Projects
None yet
3 participants