Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene Item Visibility "is visible" not working as expected for Image Slide Show #968

Closed
miko3ed opened this issue Jan 3, 2024 · 2 comments

Comments

@miko3ed
Copy link

miko3ed commented Jan 3, 2024

Describe the bug
I am seeing a strange behavior where "is visible" is not working as expected for the Image Slide Show source when using the "Source of Type" parameter, specifically for IF statements.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new Scene with a placeholder IMAGE and IMAGE SLIDE SHOW source
  2. Create a new Macro
  3. Set the IF condition for "Scene Item Visibility" and select your scene where the above placeholder images are
  4. Select "Sources of Type" and "Image Slide Show" for parameters.
  5. Turning source visibility on and off in your scene does not trigger the IF statement.

Version information

  • OS: [e.g. Windows 11]
  • OBS Version [e.g. 30.0.2]
  • Plugin Version [e.g. 1.24.2]

Additional context
If you use IF NOT and "is hidden" instead it works as expected. This behavior also is not replicated with the IMAGE source type. See the attached images and video to help explain the issue. The video first shows the "IF NOT/is hidden" combination functioning as expected and then altering the parameters to be "IF/is visible" and not functioning as expected for IMAGE SLIDE SHOW sources.

Screenshot 2024-01-03 134826
Screenshot 2024-01-03 134954
2024-01-03 13-51-51_1.webm

@WarmUpTill
Copy link
Owner

WarmUpTill commented Jan 3, 2024

If you select "Source type" as the as the input for the scene item visibility condition all sources of that type must meet the selected criteria on the selected scene.

This explains why "if not ... hidden" does not equal "if ... visible" in this particular case, since "if not four out of four sources are hidden" is not the same as "if four out of four sources are visible".

I hope that explains the unexpected behaviour! :)
I will try to make this more clear somehow.

@miko3ed
Copy link
Author

miko3ed commented Jan 3, 2024

Oh I see, I understand now, thanks for the clarification

@miko3ed miko3ed closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants