Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve dark theme #25

Closed
warmuuh opened this issue Oct 4, 2019 · 2 comments
Closed

improve dark theme #25

warmuuh opened this issue Oct 4, 2019 · 2 comments
Labels
good first issue Good for newcomers hacktoberfest

Comments

@warmuuh
Copy link
Owner

warmuuh commented Oct 4, 2019

The dark theme is usable at best. It can be improved. Some dropdowns still render in white, some fonts are not readable (black on darkgrey). the overall look&feel of this theme could probably be improved as well.
This mainly needs changes in the CSS file
@SNKyle
Copy link

SNKyle commented Oct 4, 2019

I would like to take this on if no one else has.

@warmuuh
Copy link
Owner Author

warmuuh commented Oct 5, 2019 •
edited
Loading

That would be awesome. Have a look at https://github.com/warmuuh/milkman/blob/master/milkman/src/main/resources/themes/milkman-dark.css. The CSS reference for Javafx can be seen here: https://docs.oracle.com/javafx/2/api/javafx/scene/doc-files/cssref.html
Just have a look at the theme and play around with the app, if you like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@warmuuh @SNKyle