New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstreaming the ecto-related parts #113
Comments
That's totally okay with me. The only bit that would be staying here would be the |
Cool, here is the thread: |
I saw that. I hope that isn't too discouraging. I don't think it is really needed to be in ecto_sql to be a good option. Unless I'm missing something. |
Despite this, I still think it is a good idea to split out the ecto adapter from the actual exqlite driver as we approach 1.0, call it something like |
So I was thinking about pulling the adapter into |
What are your thoughts on keeping them both in the same repo but under different directories? |
I think
But I think having them as separate projects in the same repo is fine for now. I do think there is always a tradeoff between keeping things well-separated and maintenance/developer ergonomics, and keeping them in the same repo but be separate Mix projects seems to be a nice middle ground. |
When do you think we should split the adapter? My plan is to open another repo, push this repo into it so we keep the history and then delete the parts that don't belong. |
That sounds like a good plan. I think we can do it whenever. For naming, some things to consider:
What do you think? |
I think I am okay with that plan. We should probably start renaming the adapter now and preparing for that. |
The biggest problem is, people are using this adapter now and it will break their projects if they aren't notified / we don't get a proper warning system in place. |
I wouldn't think you need to worry about that too much. I doubt there's many people who have integrated exqlite since it is such a new project and well known to be under heavy development, so breaking changes at this stage should be expected. In my opinion, a simple note in the new changelog (#114) would be sufficient. |
Yea that's fine, we just need access to that org https://github.com/elixir-sqlite/ |
@ConnorRigby, what say you? |
@kevinlang can you shoot me an email at warmwaffles@gmail.com need to co-ordinate how to get you package push permissions and what not. |
I created an account there Here is the repo of And here is the Hex package: I added you @warmwaffles as another owner. |
@kevinlang okay I'm going to open a PR here to add a changelog and remove the adapter from this repo. |
Also @kevinlang https://twitter.com/pressy4pie/status/1370406636066467840 @ConnorRigby will get us added to that org tomorrow. |
I transfered the |
Just did the same here too |
Cool. @ConnorRigby do you mind updating the Org logo to what I linked above? I can't since I don't have Owner permissions. I'll close this one out for now. |
I was going to start a new conversation in the elixir-ecto Google group to see what the path forward is for upstreaming most of the ecto related stuff into ecto_sql, now that nearly all of the integration tests are onboarded and stable.
In that scenario, this exqlite repo would mainly contain the core non-ecto driver parts, like the db_connection stuff and the NIF.
Does that sound good, @warmwaffles ? Any reservations or thoughts?
The text was updated successfully, but these errors were encountered: