Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheel release of 20.4.0 on pypi contains old i2p code #70

Open
sajith opened this issue May 21, 2020 · 1 comment
Open

Wheel release of 20.4.0 on pypi contains old i2p code #70

sajith opened this issue May 21, 2020 · 1 comment

Comments

@sajith
Copy link

sajith commented May 21, 2020

i2p should have gone in foolscap 20.4.0, but at least foolscap/connections/i2p.py is present in the .whl file. The corresponding .zip file does not contain that.

Quick test:

$ wget https://files.pythonhosted.org/packages/82/f8/be775e689bd579b102a9b7aa731fac8726e27f97a2659481098488e3eac3/foolscap-20.4.0-py2.py3-none-any.whl
$ unzip foolscap-20.4.0-py2.py3-none-any.whl
$ find . -name "i2p.py"
./foolscap/connections/i2p.py

(This is related to tahoe-lafs/tahoe-lafs#700)

@exarkun
Copy link
Collaborator

exarkun commented May 26, 2020

The fallout for Tahoe-LAFS right now is that after upgrading the Foolscap dependency, CI appears to be green almost across the board. Only two CI configurations which by chance didn't use the wheel from PyPI encountered I2P-related errors. The rest of CI claims Tahoe-LAFS I2P will continue to work with Foolscap 20.4.0 which, if true at all, appears to be unintended (and since the reason I2P support was dropped was lack of Python 3 support, will probably not remain true; also users installing Foolscap differently will get different results).

@sajith sajith changed the title Wheel release of 20.4.0 on pypi contains old code Wheel release of 20.4.0 on pypi contains old i2p code Jul 13, 2020
@exarkun exarkun mentioned this issue Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants