Correct handling of BIT STRING in DER #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomato42
force-pushed
the
bit_string
branch
2 times, most recently
from
d6fe845
to
650a2a8
Compare
|
@t8m please review |
t8m
approved these changes
Oct 17, 2019
src/ecdsa/der.py
Outdated
| the second being the remaining bytes in the string (if any); if the | ||
| `expect_unused` is specified as None, the first element of the returned | ||
| tuple will be a tuple itself, with first element being the bit string | ||
| as bytes and the second element bing the number of unused bits at the |
| if unused and not s: | ||
| raise ValueError("unused is non-zero but s is empty") | ||
| encoded_unused = int2byte(unused) | ||
| len_extra = 1 |
There was a problem hiding this comment.
Would it be good idea to either check or override the padding of the last byte here if unused is nonzero?
There was a problem hiding this comment.
checking is probably better, will do
the functions required the callees to handle the encoded length of unused bits, handle it inside the functions now also add test coverage for that deprecate the old calling convention
|
OK, still approved after the rebase and fixes. |
|
@t8m Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the first byte of the bit string in DER is the number of unused bits in the bit string, parse it properly and give expected error values if the parsing fails
fixes #120
Todo:
keys.py