Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't allow for creation of malformed DER files #139

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

tomato42
Copy link
Member

@tomato42 tomato42 commented Oct 16, 2019

when encoding in ASN.1 the public point has to use uncompressed,
compressed or hybrid representation, raw is not allowed
so disallow it in API

fixes #136

when ancoding in ASN.1 the public point has to use uncompressed,
compressed or hybrid representation, raw is not allowed
so disallow it in API
@tomato42 tomato42 added the bug unintended behaviour in ecdsa code label Oct 16, 2019
@tomato42 tomato42 added this to the v0.14 milestone Oct 16, 2019
@tomato42 tomato42 self-assigned this Oct 16, 2019
@coveralls
Copy link

coveralls commented Oct 16, 2019

Coverage Status

Coverage increased (+0.04%) to 92.122% when pulling 834fecb on tomato42:no-raw into 4e7f373 on warner:master.

@tomato42
Copy link
Member Author

@t8m please review

Copy link

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomato42 tomato42 merged commit 0c19fcb into tlsfuzzer:master Oct 17, 2019
@tomato42 tomato42 deleted the no-raw branch October 17, 2019 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintended behaviour in ecdsa code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

do not create files with malformed point encoding
3 participants