Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing with hypothesis #145

Merged
merged 13 commits into from
Oct 30, 2019
Merged

testing with hypothesis #145

merged 13 commits into from
Oct 30, 2019

Conversation

tomato42
Copy link
Member

Start using hypothesis, use it for testing the slowest test case

fixes #130

@tomato42 tomato42 added the maintenance issues related to making the project usable or testable label Oct 26, 2019
@tomato42 tomato42 added this to the v0.14 milestone Oct 26, 2019
@tomato42 tomato42 self-assigned this Oct 26, 2019
@coveralls
Copy link

coveralls commented Oct 26, 2019

Coverage Status

Coverage decreased (-0.07%) to 92.817% when pulling 62f0f9b on tomato42:hypothesis into 3538d44 on warner:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 92.22% when pulling 2518ec2 on tomato42:hypothesis into 4c92d31 on warner:master.

@tomato42 tomato42 force-pushed the hypothesis branch 8 times, most recently from faca264 to f849417 Compare October 26, 2019 20:16
@tomato42 tomato42 marked this pull request as ready for review October 26, 2019 20:35
@tomato42 tomato42 mentioned this pull request Oct 28, 2019
@tomato42 tomato42 force-pushed the hypothesis branch 3 times, most recently from e440d99 to d6dd161 Compare October 28, 2019 17:27
the curve is oficially supported, add it to star import
for easier diagnostics with hypothesis, it's nice to have the curves
named

also fix formatting in the module
for hypothesis, falsifying examples are easier to check and reproduce
when the key can be printed in form that can be put into code
use hypothesis to generate malformed signatures by introducing
different changes for different curves made with different hashes
since now test_malformed_sigs.py executes quickly, we can run it under
instrumental
since hypothesis executes good few hundred test cases, do
report that they have been run when the user runs the test suite
specified in readme...
make sure we hit the currently defined two checks in the
sigdecode_der() function
Copy link

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find any obvious problem apart from trivial typo in one of the commit messages 'test malformed string singatues with hypothesis'.
Good work!

@tomato42 tomato42 merged commit ca11bcb into tlsfuzzer:master Oct 30, 2019
@tomato42 tomato42 deleted the hypothesis branch October 30, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance issues related to making the project usable or testable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up testing of malformed signatures, increase coverage
3 participants