Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add from_signature constructor to VerifyingKey #42

Closed
wants to merge 2 commits into from

Conversation

ecdsa
Copy link

@ecdsa ecdsa commented Mar 11, 2015

This constructor creates a VerifyingKey from a signature.
It is currently implemented separately in Electrum, see:
https://github.com/spesmilo/electrum/blob/master/lib/bitcoin.py#L468
I guess it would make sense to add it to python-ecdsa instead

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.87%) to 88.43% when pulling 8a7d343 on ecdsa:fromsig into 5a6fc04 on warner:master.

Copy link
Member

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from_signature definitely needs test coverage, I'm not sure if modular_sqrt should be placed in separate file, I think it would fit well in numbertheory.py module

@tomato42 tomato42 added the feature functionality to be implemented label Sep 5, 2018
@tomato42 tomato42 added this to the someday/future milestone Sep 5, 2018
@tomato42
Copy link
Member

this is now implemented as from_public_key_recovery and from_public_key_recovery_with_digest in ecdsa.keys.VerifyingKey

@tomato42 tomato42 closed this Sep 28, 2019
@tomato42 tomato42 modified the milestones: someday/future, v0.14 Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature functionality to be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants