New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests fail against git-1.8.3 #11
Comments
It looks like the guilty git commit was git/git@e52e6f7 which changed pretty.c to use the https://github.com/warner/python-versioneer/blob/master/src/git/middle.py#L33 then parses this list. It looks for tags by recognizing a configurable prefix (in this case, |
Git-1.8.3 introduced a change to the way "$Format" strings (specifically the "%d" variable) are expanded in git-archive -generated tarballs. The list of refs has always included both branch names and tags. But in older versions, tags were not emitted any differently than branch names: the list might say: (master, HEAD, v1.0) Starting in 1.8.3, tags are marked with a distinctive "tag: " prefix, so you get: (master, HEAD, tag: v1.0) The versioneer code that deduces version tags from generated tarballs was not spotting the newly-marked tags, and falling back to reporting a full SHA1 hash as the revision, instead of the intended tag name. This change fixes the parser and restores compatibility with newer versions of git. Closes: #11.
They worked against git-1.8.2.3 (and earlier), but fail when run with git-1.8.3 (and later).
The text was updated successfully, but these errors were encountered: