Fix tests and deprecation warnings #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setuptools has changed this undocumented API, see pypa/setuptools#1299
These cause a Warning from 3.6, and will raise a SyntaxError in some future version https://docs.python.org/3/whatsnew/3.6.html#deprecated-python-behavior
moggers87
added a commit
to Inboxen/Inboxen
that referenced
this pull request
Oct 29, 2018
Reported upstream, python-versioneer/python-versioneer#190
moggers87
added a commit
to Inboxen/Inboxen
that referenced
this pull request
Oct 29, 2018
Reported upstream, python-versioneer/python-versioneer#190
|
Would be a good thing to merge this one as it will resolve |
1 task
|
@warner is it possible to take a look at this? |
Merged
Open
|
Closed and reopened to check whether this still fixes Travis... |
|
Alas, things are failing. If you care to have another go at this, please do. Otherwise I'll have a look this next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are currently broken in master, this PR fixes that.
Most of the work was making sure that installed packages used for testing were old enough to work with EOL'd versions of Python.