feat: initial import of all icons from Figma #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaRybkina
force-pushed
the
import-icons
branch
2 times, most recently
from
2f34ec6
to
7e8d4a1
Compare
AnnaRybkina
force-pushed
the
import-icons
branch
from
7e8d4a1
to
1aa48f1
Compare
AnnaRybkina
force-pushed
the
import-icons
branch
2 times, most recently
from
e9854dd
to
3612fbd
Compare
AnnaRybkina
force-pushed
the
import-icons
branch
from
3612fbd
to
ff51e26
Compare
siljec
reviewed
Aug 25, 2023
scripts/render.js
Outdated
Comment on lines
13
to
14
| return { | ||
| name: path.parse(svgPath).name, |
There was a problem hiding this comment.
Can we show the "icon name" instead of just "icon_16":
Something like this for example:
Suggested change
| return { | |
| name: path.parse(svgPath).name, | |
| const regex = /dist\/(.*?)\/icon/; | |
| const match = svgPath.match(regex); | |
| let iconName = path.parse(svgPath).name; | |
| if (match && match[1]) { | |
| iconName = match[1]; | |
| } | |
| return { | |
| name: iconName, |
BalbinaK
reviewed
Aug 25, 2023
scripts/render.js
Outdated
| const data = fs.readFileSync(svgPath, "utf-8"); | ||
| const {size} = getNameAndSize(svgPath); | ||
| return { | ||
| name: path.parse(svgPath).name, |
There was a problem hiding this comment.
This will return the name of the svg file (like icon_24), while it's more the parent directory that we'd need for the preview page (like active-ads). I tested that this would give us what we need:
Suggested change
| name: path.parse(svgPath).name, | |
| name: path.basename(path.dirname(svgPath)), |
Wdyt?
There was a problem hiding this comment.
oh that was a way cleaner way to do it!
There was a problem hiding this comment.
That is great, committed 🙌 3727939
AnnaRybkina
changed the title
|
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: https://nmp-jira.atlassian.net/browse/WARP-221, https://nmp-jira.atlassian.net/browse/WARP-223