feat: Handle i18n for vue #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaRybkina
reviewed
Sep 28, 2023
scripts/output/vue.js
Outdated
| getSVGs().forEach(({ svg, filename, exportName }) => { | ||
| // Create Vue Icon | ||
| getSVGs().forEach(({ svg, filename, exportName, name }) => { | ||
| // Handle i18n of icon title |
There was a problem hiding this comment.
This comment for me doesn't add any useful information as the next line is actually to create an icon name and not handle i18n. So maybe it is better to remove this one or move it somewhere else, before line 20 for example. Wdyt?
There was a problem hiding this comment.
That’s true! I can either move it up to before line 20 or refactor the comment. :)
AnnaRybkina
reviewed
Sep 28, 2023
scripts/output/vue.js
Outdated
| // Create Vue Icon | ||
| getSVGs().forEach(({ svg, filename, exportName, name }) => { | ||
| // Handle i18n of icon title | ||
| const iconNameCamelCase = exportName.replace('Icon', '').replace(/\d+/g, ''); |
There was a problem hiding this comment.
Just a suggestion to simplify but feel free to ignore this one if you don't like it.
Suggested change
| const iconNameCamelCase = exportName.replace('Icon', '').replace(/\d+/g, ''); | |
| const iconNameCamelCase = exportName.replace(/Icon|\d+/g, ''); |
AnnaRybkina
approved these changes
Sep 28, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
# [1.1.0-next.2](v1.1.0-next.1...v1.1.0-next.2) (2023-09-28) ### Features * Handle i18n for vue ([#14](#14)) ([2cf4fdb](2cf4fdb))
github-actions bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
# [1.1.0](v1.0.0...v1.1.0) (2023-10-19) ### Bug Fixes * add 9BA8BA to exchange with currentColor ([#17](#17)) ([bea742a](bea742a)) * add leading slash to dest in crowdin config ([#23](#23)) ([d1170b6](d1170b6)) * add more missing titles ([#35](#35)) ([91f2b78](91f2b78)) * element icons names ([#16](#16)) ([0d550c8](0d550c8)) * Fix bundling ([#20](#20)) ([6ea9874](6ea9874)) * make sure finnish translations aren't gitignored ([#40](#40)) ([5c49b2b](5c49b2b)) * pnpm lockfile ([6529014](6529014)) * set next as default prerelease branch ([#12](#12)) ([bb0be72](bb0be72)) * update crowdin.yaml with leading slash ([bd09d68](bd09d68)) * update Readme text ([156d4ed](156d4ed)) * update script with improved destination in crowdin ([#34](#34)) ([30f4c92](30f4c92)) * use proper language placeholder in translations ([#22](#22)) ([4425b66](4425b66)) ### Features * Generate individual icons ([#39](#39)) ([dd74394](dd74394)) * Handle i18n for elements ([#19](#19)) ([8a27850](8a27850)) * Handle i18n for vue ([#14](#14)) ([2cf4fdb](2cf4fdb)) * i18n for react ([#9](#9)) ([10e41bc](10e41bc)) ### Reverts * Revert "feat:Handle i18n for elements (#15)" (#18) ([6bfee40](6bfee40)), closes [#15](#15) [#18](#18)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor script for generating vue icons to also handle i18n + add translated title for Vue icons (found in scripts/output/vue.js)
To test:
pnpm build:vuein this branchpnpm build<icon-info16 />