Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add 9BA8BA to exchange with currentColor #17

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

AnnaRybkina
Copy link
Contributor

We have discovered that we have a new color that should be added to the magicColors array to be exchanged with currentColor.
@Skadefryd had a great point about the way we are adding the icons to Figma. We should only use one color #717171a or any other "green screen" color that would be used for coloration. And then it will be easy to exchange this color in build.js when we optimize our icons and we can get rid of the magicColors array and only use one string.

@AnnaRybkina AnnaRybkina requested a review from a team October 2, 2023 13:50
@AnnaRybkina AnnaRybkina merged commit bea742a into next Oct 3, 2023
1 check passed
@AnnaRybkina AnnaRybkina deleted the one-more-color-icon-42 branch October 3, 2023 07:31
github-actions bot pushed a commit that referenced this pull request Oct 3, 2023
# [1.1.0-next.4](v1.1.0-next.3...v1.1.0-next.4) (2023-10-03)

### Bug Fixes

* add 9BA8BA to exchange with currentColor ([#17](#17)) ([bea742a](bea742a))
github-actions bot pushed a commit that referenced this pull request Oct 19, 2023
# [1.1.0](v1.0.0...v1.1.0) (2023-10-19)

### Bug Fixes

* add 9BA8BA to exchange with currentColor ([#17](#17)) ([bea742a](bea742a))
* add leading slash to dest in crowdin config ([#23](#23)) ([d1170b6](d1170b6))
* add more missing titles ([#35](#35)) ([91f2b78](91f2b78))
* element icons names ([#16](#16)) ([0d550c8](0d550c8))
* Fix bundling ([#20](#20)) ([6ea9874](6ea9874))
* make sure finnish translations aren't gitignored ([#40](#40)) ([5c49b2b](5c49b2b))
* pnpm lockfile ([6529014](6529014))
* set next as default prerelease branch ([#12](#12)) ([bb0be72](bb0be72))
* update crowdin.yaml with leading slash ([bd09d68](bd09d68))
* update Readme text ([156d4ed](156d4ed))
* update script with improved destination in crowdin ([#34](#34)) ([30f4c92](30f4c92))
* use proper language placeholder in translations ([#22](#22)) ([4425b66](4425b66))

### Features

* Generate individual icons ([#39](#39)) ([dd74394](dd74394))
* Handle i18n for elements ([#19](#19)) ([8a27850](8a27850))
* Handle i18n for vue ([#14](#14)) ([2cf4fdb](2cf4fdb))
* i18n for react ([#9](#9)) ([10e41bc](10e41bc))

### Reverts

* Revert "feat:Handle i18n for elements (#15)" (#18) ([6bfee40](6bfee40)), closes [#15](#15) [#18](#18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants