fix: add part-attribute to svg for elements-script #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would say maybe remove the crowdin file and the translation changes from this PR until we get an answer from the i18n team :) |
I can merge these as part of this PR: #51 |
BalbinaK
approved these changes
Nov 9, 2023
imprashast
approved these changes
Nov 9, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
# [1.2.0](v1.1.1...v1.2.0) (2023-11-13) ### Bug Fixes * add part-attribute to svg for elements-script ([#50](#50)) ([8a056c7](8a056c7)) * externalize lingui from all icons ([eae5388](eae5388)) ### Features * Expose individual named exports for React & Vue ([#54](#54)) ([1ab02f8](1ab02f8)) ### Reverts * **crowdin.yml:** revert formatting that makes crowdin.yml format invalid ([#52](#52)) ([fc4036b](fc4036b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
part="w-icon-${name}-${size}-part"to<svg>in elements-script.NOTE: This is part of implementing changes to the expandable-component in the elements-repo in order to be able to style the svg from a warp-icon that is inside a shadow-DOM. See draft-PR in elements-repo: warp-ds/elements#107