feat: add 16px icons and update all svgs #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght value When we copy over svgs from Figma, it sometimes happens that those files have invalid height/width applied to svg element. By printing a list of invalid icons, we are increasing our chances of spotting those tiny errors.
imprashast
approved these changes
Feb 1, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
# [1.5.0-next.4](v1.5.0-next.3...v1.5.0-next.4) (2024-02-02) ### Features * add 16px icons and update all svgs ([#91](#91)) ([a5f5794](a5f5794))
github-actions bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
# [1.5.0](v1.4.0...v1.5.0) (2024-02-02) ### Bug Fixes * locale detection for icons ([#81](#81)) ([f97d09f](f97d09f)) * update oikotie market icons ([#83](#83)) ([d4bad16](d4bad16)) * update strings for logout, picture-stack and organize ([#90](#90)) ([f381be3](f381be3)) ### Features * add 16px icons and update all svgs ([#91](#91)) ([a5f5794](a5f5794)) * add missing 16px icons and a geometric-shapes icon ([#84](#84)) ([c22fd1b](c22fd1b)) * add missing icons ([#88](#88)) ([f5db3ac](f5db3ac))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WARP-486
pnpm build:reactwhich prints icons that have invalid sizes - can be helpful when we need to manually update icons using svgs provided in a zip file exported from Figma