Implements client support for OpenSSH Certificates #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: implements openssh supported, tested with ed25519 certs
chore: cleanup
|
Thank you - much appreciated! |
|
@all-contributors please add @shoaibmerchant for code |
|
I've put up a pull request to add @shoaibmerchant! 🎉 |
Eugeny
pushed a commit
that referenced
this pull request
May 4, 2024
Adds @shoaibmerchant as a contributor for code. This was requested by Eugeny [in this comment](#278 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
You're welcome. Thanks for this rust implementation for SSH, it is helping us build ssh into our cli. I am keen to try out warp-tech too! Also on a side note, I just saw that I missed some formatting, I will send a PR in a while. |
|
No worries, I've already fixed it myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using OpenSSH Certificates based on OpenSSH Specs using the existing
PublicKeyauthentication.Approach:
Adds a new
authenticate_openssh_cert()method, similar toauthenticate_publickey()for passing certificate and the private key for authentication and signature generation. Internally a newAuthMethod::OpenSSHCertificateis added to handle certificate specific authentication flow.Changes include -
examples/client_exec_interactive.rswith an optional argument to pass the openssh certificate path.ssh-keyandssh-encodingare added fromRustCrypto/SSHfor parsing, encoding.The server-side support for this might be tricky, I am yet to explore.