Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support oh-my-fish prompt #3796

Open
iMonZ opened this issue Oct 21, 2023 · 5 comments
Open

Support oh-my-fish prompt #3796

iMonZ opened this issue Oct 21, 2023 · 5 comments
Labels
Feature requests Feature Requests

Comments

@iMonZ
Copy link

iMonZ commented Oct 21, 2023

Discord username (optional)

igoldgamer

Describe the bug

The Fish shell has many problems inside warp

  1. I get every time when I start this shell this message:
    funcsave: wrote /Users/mvg/.config/fish/functions/python.fish
  2. When I'm in a git repo, the fish shell should tell me the branch and the current status with Ligatures.
    But I get this instead:
    ~/Downloads/bewell-be git:(develop)
    But inside the iTerm 2 and Terminal shell everything works as expected.

Using oh-my-fish and the bobthefish theme

To reproduce

Using the fish shell as default.
Implementing the Warp integration

Expected behavior

No response

Screenshots

How it looks in Warp:
Screenshot 2023-10-21 at 22 45 58
How it should look like (iTerm 2):
Screenshot 2023-10-21 at 22 46 25

Operating system

macOS

Operating system and version

14.1

Shell Version

fish, version 3.6.1

Current Warp version

v0.2023.10.17.08.03.stable_01

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

Yes, this issue prevents me from using Warp daily.

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

@iMonZ iMonZ added the Bugs Bugs, Hangs, Crash, and Freezes label Oct 21, 2023
@iMonZ
Copy link
Author

iMonZ commented Oct 21, 2023

Btw. I use the JetBrainsMono Nerd Font which actually supports for Ligatures

@iMonZ iMonZ changed the title Fish shell is very buggy Fish shell with oh-my-fish is very buggy Oct 21, 2023
@dannyneira
Copy link
Member

Hey @iMonZ, what you're seeing right now is the default prompt that comes with Warp. In order to enable the custom prompt (PS1), like the one you're seeing in iterm, you need to right-click on the prompt and click Edit Prompt, then select the "Shell prompt PS1". Please see more in our prompt docs. https://docs.warp.dev/features/prompt#how-to-access-it as well as my demo below.

CleanShot.2023-10-23.at.11.41.26.mp4

Hope this helps, please let us know if you continue to have any issues or close if all is good.

@iMonZ
Copy link
Author

iMonZ commented Oct 23, 2023

Hey @iMonZ, what you're seeing right now is the default prompt that comes with Warp. In order to enable the custom prompt (PS1), like the one you're seeing in iterm, you need to right-click on the prompt and click Edit Prompt, then select the "Shell prompt PS1". Please see more in our prompt docs. https://docs.warp.dev/features/prompt#how-to-access-it as well as my demo below.

CleanShot.2023-10-23.at.11.41.26.mp4

Hope this helps, please let us know if you continue to have any issues or close if all is good.

Perfect! Thanks that worked for me

@iMonZ iMonZ closed this as completed Oct 23, 2023
@iMonZ
Copy link
Author

iMonZ commented Oct 23, 2023

Hey @iMonZ, what you're seeing right now is the default prompt that comes with Warp. In order to enable the custom prompt (PS1), like the one you're seeing in iterm, you need to right-click on the prompt and click Edit Prompt, then select the "Shell prompt PS1". Please see more in our prompt docs. https://docs.warp.dev/features/prompt#how-to-access-it as well as my demo below.

CleanShot.2023-10-23.at.11.41.26.mp4

Hope this helps, please let us know if you continue to have any issues or close if all is good.

Oh wait but the:
Funcsave message is still coming up

@iMonZ iMonZ reopened this Oct 23, 2023
@dannyneira
Copy link
Member

Heard @iMonZ, we'll have to change this to a feature request to support the oh-my-fish prompt in Warp. It may be working unofficially in some cases, but we've not sorted out the bugs like this one yet.

To anyone else interested in this feature, please add a 👍 to the original post at the top to signal that you want this feature, and subscribe if you'd like to be notified.

@dannyneira dannyneira changed the title Fish shell with oh-my-fish is very buggy Support oh-my-fish prompt Feb 13, 2024
@dannyneira dannyneira added Feature requests Feature Requests and removed Bugs Bugs, Hangs, Crash, and Freezes labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature requests Feature Requests
Projects
None yet
Development

No branches or pull requests

2 participants