Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support blocks feature for trzsz-ssh ( tssh ) in search mode #3960

Open
lonnywong opened this issue Dec 13, 2023 · 8 comments
Open

Support blocks feature for trzsz-ssh ( tssh ) in search mode #3960

lonnywong opened this issue Dec 13, 2023 · 8 comments
Labels
Feature requests Feature Requests

Comments

@lonnywong
Copy link

lonnywong commented Dec 13, 2023

Discord username (optional)

No response

Describe the solution you'd like?

In the shell function is_interactive_ssh_session,
change [[ ${#ARGS[@]} -ne 1 ]] to [[ ${#ARGS[@]} -ne 1 ]] && [[ $(command ssh -V 2>&1) != "trzsz ssh"* ]]:

is_interactive_ssh_session () {
	ARGS=()
	# ...
	if [[ ${#ARGS[@]} -ne 1 ]] && [[ $(command ssh -V 2>&1) != "trzsz ssh"* ]]
	then
		return 1
	fi
}

In the shell function warp_ssh_helper, using -oRemoteCommand instead.
change command ssh -o ControlMaster=yes -o ControlPath=$SSH_SOCKET_DIR/$WARP_SESSION_ID -t "${@:1}" "..." to:

warp_ssh_helper () {
command ssh -o ControlMaster=yes -o ControlPath=$SSH_SOCKET_DIR/$WARP_SESSION_ID -t -oRemoteCommand="
export TERM_PROGRAM='WarpTerminal'
# ...
" "${@:1}"
}

Is your feature request related to a problem? Please describe.

trzsz-ssh ( tssh ) supports the Warp blocks feature if ssh login directly. But it's not working in tssh search mode.

Steps to reproduce:

brew install trzsz-ssh
sudo ln -sv $(which tssh) /usr/local/bin/ssh

# It works if ssh login directly
ssh server

#  It's not working in search mode. tssh will enter search mode without any argument.
ssh

# It works with an argument. e.g., there's a server alias in `~/.ssh/config` contains `s`:
ssh s

Additional context

How important is this feature to you?

3

Warp Internal (ignore) - linear-label:770f6576-d6c0-4e4f-a259-fc64b5156087

None

@lonnywong lonnywong added the Feature requests Feature Requests label Dec 13, 2023
@dannyneira
Copy link
Member

Hi @lonnywong Thanks for submitting such a details feature request!

To anyone else interested in this feature, please add a :+1: to the original post at the top to signal that you want this feature, and subscribe if you'd like to be notified.

@drag0n-app
Copy link

+1

3 similar comments
@zlsq
Copy link

zlsq commented Jan 24, 2024

+1

@paststrange
Copy link

+1

@00arthur00
Copy link

+1

@fisherwei
Copy link

+1

2 similar comments
@SunDaydream
Copy link

+1

@gaoxiang0421
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature requests Feature Requests
Projects
None yet
Development

No branches or pull requests

9 participants