Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Custom Themes > Clone entire repo #4896

Closed
1 task done
mudittiwari2000 opened this issue May 9, 2024 · 2 comments
Closed
1 task done

Documentation: Custom Themes > Clone entire repo #4896

mudittiwari2000 opened this issue May 9, 2024 · 2 comments
Labels
Bugs Bugs, Hangs, Crash, and Freezes

Comments

@mudittiwari2000
Copy link

Dupe Check

Describe the bug

In the documentation, for custom themes, the section where a command is given for cloning entire repo is incorrect. It didn't work for me, and the issue wasn't obvious.

Command I mentioned above:

cd ~/.warp/
git clone https://github.com/warpdotdev/themes.git

The issue:
Since the above command is a set of two commands, if ~/.warp directory doesn't already exist, the first command cd ~/.warp would fail but since no shorthand operator like && is used in this command in the docs, the next command would run just fine and the github repo for themes will be cloned in a directory called /themes at pwd. Instead, maybe add a shorthand or maybe create the ~/.warp directory first before running both the commands?

Possible Fix #1:

cd ~/.warp/ && git clone https://github.com/warpdotdev/themes.git

Possible Fix #2:

mkdir ~/.warp
cd ~/.warp/
git clone https://github.com/warpdotdev/themes.git

To reproduce

  1. Make sure ~/.warp is deleted.
  2. Run the following commands in the terminal
cd ~/.warp/
git clone https://github.com/warpdotdev/themes.git
  1. Notice you're still in the same directory.
  2. This would fail to install the themes in Warp.

Expected behavior

No response

Screenshots

No response

Operating system

MacOS

Operating system and version

Sonoma 14.4.1

Shell Version

zsh 5.9 (x86_64-apple-darwin23.0)

Current Warp version

v0.2024.04.30.08.02.stable_01

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

@mudittiwari2000 mudittiwari2000 added the Bugs Bugs, Hangs, Crash, and Freezes label May 9, 2024
@dannyneira
Copy link
Member

Hi @mudittiwari2000 thanks for letting us know. checking to confirm, but I think ~/.warp folder may not be automatically created upon installing Warp for Mac. If this is the case, you're correct and we need to update that command to include making the dir. I'll post updates to this thread.

@dannyneira
Copy link
Member

Updated the custom themes docs to include making the directory before cd and clone repo.
Thanks for helping to make our docs a bit better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugs Bugs, Hangs, Crash, and Freezes
Projects
None yet
Development

No branches or pull requests

2 participants