Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add playwright workflows #108

Merged
merged 6 commits into from Aug 26, 2022

Conversation

DominusKelvin
Copy link
Contributor

@DominusKelvin DominusKelvin commented Aug 24, 2022

Discord username (optional), please include so we can attribute you with our Contributor role (like so elvis#4747)

KOO#8922

Description of changes (updated or new workflows)

Add 9 Playwright workflows

Copy link
Member

@alokedesai alokedesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for contributing! Have a small comment about updating the name for each of the workflows, but other than that it looks great!

specs/playwright/auto-generate-tests-with-codegen.yaml Outdated Show resolved Hide resolved
@DominusKelvin
Copy link
Contributor Author

@alokedesai I've added Playwright in the name of all workflows. Let me know if any further edits are needed :)

Copy link
Member

@alokedesai alokedesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing!

@alokedesai
Copy link
Member

Thank you @DominusKelvin!

@alokedesai alokedesai merged commit 57af410 into warpdotdev:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants