Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Meroxa workflows #109

Merged
merged 5 commits into from Aug 26, 2022
Merged

Conversation

raulb
Copy link
Contributor

@raulb raulb commented Aug 25, 2022

Discord username (optional) please include so we can attribute you with our Contributor role (like so elvis#4747)

raulb#3523

Description of changes (updated or new workflows)

  • Adds new workflows for Meroxa
  • Fix README

@raulb raulb force-pushed the add-meroxa-workflows branch 2 times, most recently from bf06a8b to a9b95f9 Compare August 25, 2022 20:38
@raulb raulb marked this pull request as ready for review August 26, 2022 10:03
Copy link
Member

@alokedesai alokedesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just two small comments if you don't mind addressing before I approve

specs/meroxa/resources_create_bigquery.yaml Outdated Show resolved Hide resolved
specs/meroxa/resources_create_bigquery.yaml Outdated Show resolved Hide resolved
@raulb raulb requested a review from alokedesai August 26, 2022 14:45
@raulb
Copy link
Contributor Author

raulb commented Aug 26, 2022

Thank you @alokedesai for the prompt review! Just made your suggested changes.

Copy link
Member

@alokedesai alokedesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again for contributing :D

@alokedesai alokedesai merged commit cb07017 into warpdotdev:main Aug 26, 2022
@raulb raulb deleted the add-meroxa-workflows branch August 29, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants