Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs-shell): ✨ add new shell array workflows #54

Closed
wants to merge 3 commits into from
Closed

feat(specs-shell): ✨ add new shell array workflows #54

wants to merge 3 commits into from

Conversation

Wyatt-Stanke
Copy link
Contributor

Woo! Adds some cool array shell workflows. Also, my third pr for this repo! 🎉

Discord: ifthisthenthat#0001 (just wondering if I can get the contributor role)

Copy link
Member

@alokedesai alokedesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! Just had a few comments on how to make these workflows clearer

specs/shell/array_append_values.yaml Show resolved Hide resolved
specs/shell/array_create.yaml Outdated Show resolved Hide resolved
@alokedesai
Copy link
Member

@Wyatt-Stanke Friendly ping on this--mind addressing the open comments on this PR or close this out? I'm trying to reduce the number of stale PRs. Thanks so much!

@Wyatt-Stanke
Copy link
Contributor Author

Hey! Sorry, I completely forgot about this PR! I will update!

@Wyatt-Stanke
Copy link
Contributor Author

LGTM!

@Wyatt-Stanke
Copy link
Contributor Author

Sorry--can't fix the merge conflicts. I have zero idea how to do it on the command line and it's too complex for GitHub's web editor.

@elviskahoro
Copy link
Member

@Wyatt-Stanke I just opened a PR that's a clean version of this one:
#102

Thanks for doing all this, we can't let the time you already put in go to waste

@Wyatt-Stanke
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants