consider using environment vars for terminal #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding environment variables for columns and lines can fix terminal issues when entering a container. also ```-e COLUMNS=$COLUMNS -e LINES=$LINES -e TERM=$TERM``` if no command subprocess is desired
|
Is this still an open issue with Docker? My understanding is this was fixed a few years ago, see moby/moby#33910 and moby/moby#37172 |
|
@bdmorin Friendly ping on this! Mind addressing the comment or closing out if this is no longer relevant. Thanks! |
|
Closing this out per my comment above. Feel free to reopen if you're still working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding environment variables for columns and lines can fix terminal issues when entering a container.
also
-e COLUMNS=$COLUMNS -e LINES=$LINES -e TERM=$TERMif no command subprocess is desiredDiscord username (optional) please include so we can attribute you with our Contributor role (like so elvis#4747)
Description of changes (updated or new workflows)