Changed all boolean casts that were using Boolean() function to use d…

…ouble negation (!!), which is faster: http://stackoverflow.com/questions/15335452/why-is-boolean-so-slow-in-javascript
handsontable · Aug 1, 2013 · 9c2915d · 9c2915d
1 parent 2930029
commit 9c2915d
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/extensions/jquery.handsontable.removeRow.js b/extensions/jquery.handsontable.removeRow.js
@@ -9,7 +9,7 @@
   function init() {
     var instance = this;
 
-    var pluginEnabled = Boolean(instance.getSettings().removeRowPlugin);
+    var pluginEnabled = !!(instance.getSettings().removeRowPlugin);
 
     if (pluginEnabled) {
       bindMouseEvents();

diff --git a/src/plugins/columnSorting.js b/src/plugins/columnSorting.js
@@ -12,7 +12,7 @@ function HandsontableColumnSorting() {
     var sortingSettings = instance.getSettings().columnSorting;
     var sortingColumn, sortingOrder;
 
-    sortingEnabled = Boolean(sortingSettings);
+    sortingEnabled = !!(sortingSettings);
 
     if (sortingEnabled) {
       instance.sortIndex = [];

diff --git a/src/plugins/contextMenu.js b/src/plugins/contextMenu.js
@@ -1,7 +1,7 @@
 (function(Handsontable){
   function init(){
     var instance = this;
-    var pluginEnabled = Boolean(instance.getSettings().contextMenu);
+    var pluginEnabled = !!(instance.getSettings().contextMenu);
 
     if(pluginEnabled){
       createContextMenu.call(instance);

diff --git a/src/plugins/manualColumnMove.js b/src/plugins/manualColumnMove.js
@@ -103,7 +103,7 @@ function HandsontableManualColumnMove() {
   this.init = function (source) {
     var instance = this;
 
-    var manualColMoveEnabled = Boolean(this.getSettings().manualColumnMove);
+    var manualColMoveEnabled = !!(this.getSettings().manualColumnMove);
 
     if (manualColMoveEnabled) {
       var initialManualColumnPositions = this.getSettings().manualColumnMove;

diff --git a/src/plugins/manualColumnResize.js b/src/plugins/manualColumnResize.js
@@ -132,7 +132,7 @@ function HandsontableManualColumnResize() {
 
   this.init = function (source) {
     var instance = this;
-    var manualColumnWidthEnabled = Boolean(this.getSettings().manualColumnResize);
+    var manualColumnWidthEnabled = !!(this.getSettings().manualColumnResize);
 
     if (manualColumnWidthEnabled) {
       var initialColumnWidths = this.getSettings().manualColumnResize;

diff --git a/src/plugins/persistentState.js b/src/plugins/persistentState.js
@@ -69,7 +69,7 @@ function Storage(prefix) {
       var instance = this,
         pluginSettings = instance.getSettings()['persistentState'];
 
-      plugin.enabled = Boolean(pluginSettings);
+      plugin.enabled = !!(pluginSettings);
 
       if (!plugin.enabled) {
         removeHooks.call(instance);