/
WartRemover.scala
650 lines (614 loc) · 22.7 KB
/
WartRemover.scala
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
package wartremover
import java.nio.file.Path
import java.nio.charset.StandardCharsets
import org.wartremover.InspectParam
import org.wartremover.InspectResult
import sbt.*
import sbt.Keys.*
import sbt.SlashSyntax.HasSlashKey
import sjsonnew.JsonFormat
import sjsonnew.support.scalajson.unsafe.CompactPrinter
import wartremover.InspectWart.Type
import java.io.FileInputStream
import java.lang.reflect.Modifier
import java.net.URLClassLoader
import java.util.zip.ZipInputStream
import scala.annotation.tailrec
import scala.collection.concurrent.TrieMap
import scala.concurrent.Await
import scala.concurrent.ExecutionContext
import scala.concurrent.Future
import scala.concurrent.duration.DurationInt
import scala.util.Using
object WartRemover extends sbt.AutoPlugin {
override def trigger = allRequirements
object autoImport {
val WartremoverTag = Tags.Tag("wartremover")
val wartremoverTask = InputKey[InspectResult]("wartremover", "run wartremover by TASTy inspector")
val wartremoverFailIfWartLoadError = settingKey[Boolean]("")
val wartremoverInspect = taskKey[InspectResult]("run wartremover by TASTy inspector")
val wartremoverInspectOutputFile = settingKey[Option[File]]("")
val wartremoverInspectOutputStandardReporter = settingKey[Boolean]("")
val wartremoverInspectFailOnErrors = settingKey[Boolean]("")
val wartremoverInspectScalaVersion = settingKey[String]("scala version for wartremoverInspect task")
val wartremoverInspectSettings = settingKey[Seq[String]]("extra settings for run inspector")
val wartremoverErrors = settingKey[Seq[Wart]]("List of Warts that will be reported as compilation errors.")
val wartremoverWarnings = settingKey[Seq[Wart]]("List of Warts that will be reported as compilation warnings.")
val wartremoverExcluded = taskKey[Seq[File]]("List of files to be excluded from all checks.")
val wartremoverClasspaths = taskKey[Seq[String]]("List of classpaths for custom Warts")
val wartremoverCrossVersion = settingKey[CrossVersion]("CrossVersion setting for wartremover")
val wartremoverDependencies = settingKey[Seq[ModuleID]]("List of dependencies for custom Warts")
val wartremoverPluginJarsDir = settingKey[Option[File]]("workaround for https://github.com/sbt/sbt/issues/6027")
val Wart = wartremover.Wart
val Warts = wartremover.Warts
}
import autoImport._
override def globalSettings = Seq(
Global / concurrentRestrictions += Tags.limit(WartremoverTag, 2),
wartremoverInspectScalaVersion := {
"3.3.1"
},
wartremoverInspectSettings := Nil,
excludeLintKeys += wartremoverInspectOutputFile,
excludeLintKeys += wartremoverInspectScalaVersion,
wartremoverCrossVersion := CrossVersion.full,
wartremoverDependencies := Nil,
wartremoverErrors := Nil,
wartremoverWarnings := Nil,
wartremoverExcluded := Nil,
wartremoverClasspaths := Nil
)
private[this] def runInspector(
projectName: String,
base: File,
param: InspectParam,
scalaV: String,
launcher: File,
scalaSources: Seq[File],
forkOptions: ForkOptions,
jarFiles: Seq[Seq[Byte]],
extraSettings: Seq[String],
): Either[Int, String] = {
val buildSbt =
s"""autoScalaLibrary := false
|name := "${projectName}"
|logLevel := Level.Warn
|scalaVersion := "${scalaV}"
|libraryDependencies := Seq(
| "org.scala-lang" % "scala3-tasty-inspector_3" % "${scalaV}",
| "org.wartremover" % "wartremover-inspector_3" % "${Wart.PluginVersion}",
|)
|Compile / sources := Nil
|${extraSettings.mkString("\n\n")}
|""".stripMargin
IO.withTemporaryDirectory { dir =>
jarFiles.zipWithIndex.foreach { case (jarBytes, i) =>
IO.write(dir / "lib" / s"warts${i}.jar", jarBytes.toArray)
}
val forkOpt = forkOptions.withWorkingDirectory(dir)
val out = dir / "out.json"
val in = dir / "in.json"
IO.copy(
scalaSources.flatMap { f =>
IO.relativize(base, f).map { x =>
f -> (dir / x)
}
}
)
IO.write(dir / "build.sbt", buildSbt.getBytes(StandardCharsets.UTF_8))
IO.write(in, param.toJsonString.getBytes(StandardCharsets.UTF_8))
val ret = Fork.java.apply(
forkOpt,
Seq(
"-jar",
launcher.getCanonicalPath,
Seq(
"runMain",
"org.wartremover.WartRemoverInspector",
s"--input=${in.getCanonicalPath}",
s"--output=${out.getCanonicalPath}",
).mkString(" ")
)
)
if (ret == 0) {
Right(IO.read(out))
} else {
Left(ret)
}
}
}
private[this] def copyToCompilerPluginJarsDir(
src: File,
jarDir: Option[File],
base: File,
log: Logger
): Option[Path] = {
jarDir match {
case Some(compilerPluginsDir) =>
if (src.isFile) {
val jarName = src.getName
val targetJar = compilerPluginsDir / jarName
if (!targetJar.isFile) {
IO.copyFile(
sourceFile = src,
targetFile = targetJar
)
log.debug(s"copy from $src to $targetJar")
} else {
log.debug(s"file $targetJar already exists")
}
Some(base.toPath.relativize(targetJar.toPath))
} else {
if (!src.isDirectory) {
log.debug(s"neither file nor directory!? $src")
}
Some(base.toPath.relativize(src.toPath))
}
case None =>
log.debug("jarDir is None")
None
}
}
def scalacOptionSetting(k: TaskKey[Seq[String]]): Def.SettingsDefinition = {
k := {
val prefix = "-Xplugin:"
k.value.map { opt =>
if (opt startsWith prefix) {
val originalPluginFile = file(opt.drop(prefix.length))
copyToCompilerPluginJarsDir(
src = originalPluginFile,
jarDir = wartremoverPluginJarsDir.value,
base = (LocalRootProject / baseDirectory).value,
log = streams.value.log
).map {
prefix + _
}.getOrElse(opt)
} else {
opt
}
}.distinct
}
}
def dependsOnLocalProjectWarts(p: Reference, configuration: Configuration = Compile): Def.SettingsDefinition = {
wartremoverClasspaths ++= {
(p / configuration / fullClasspath).value.map(_.data).map { f =>
copyToCompilerPluginJarsDir(
src = f,
jarDir = wartremoverPluginJarsDir.value,
base = (LocalRootProject / baseDirectory).value,
log = streams.value.log
).map("file:" + _).getOrElse(f.toURI.toString)
}
}
}
private[this] implicit val inspectParamFormat: JsonFormat[InspectParam] = {
import sjsonnew.BasicJsonProtocol.*
caseClass8(InspectParam, InspectParam.unapply)(
"tastyFiles",
"dependenciesClasspath",
"wartClasspath",
"errorWarts",
"warningWarts",
"exclude",
"failIfWartLoadError",
"outputStandardReporter",
)
}
private[this] implicit val inspectResultFormat: JsonFormat[InspectResult] = {
import sjsonnew.BasicJsonProtocol.*
implicit val positionInstance: JsonFormat[org.wartremover.Position] =
caseClass8(org.wartremover.Position, org.wartremover.Position.unapply)(
"start",
"startLine",
"startColumn",
"end",
"endLine",
"endColumn",
"path",
"sourceCode",
)
implicit val diagnosticInstance: JsonFormat[org.wartremover.Diagnostic] =
caseClass3(org.wartremover.Diagnostic, org.wartremover.Diagnostic.unapply)(
"message",
"wart",
"position",
)
caseClass3(InspectResult.apply, InspectResult.unapply)(
"errors",
"warnings",
"stderr",
)
}
private[this] implicit class JsonOps[A](private val self: A) extends AnyVal {
def toJsonString(implicit w: sjsonnew.JsonWriter[A]): String = {
val builder = new sjsonnew.Builder(sjsonnew.support.scalajson.unsafe.Converter.facade)
w.write(self, builder)
CompactPrinter.apply(
builder.result.getOrElse(sys.error("invalid json"))
)
}
}
private[this] implicit class JsonStringOps(private val string: String) extends AnyVal {
def decodeFromJsonString[A](implicit r: sjsonnew.JsonReader[A]): A = {
val json = sjsonnew.support.scalajson.unsafe.Parser.parseUnsafe(string)
val unbuilder = new sjsonnew.Unbuilder(sjsonnew.support.scalajson.unsafe.Converter.facade)
r.read(Some(json), unbuilder)
}
}
private[this] def inspectTask(x: Configuration): Seq[Def.Setting[?]] = Def.settings(
x / wartremoverInspectOutputFile := None,
x / wartremoverTask := Def.inputTaskDyn {
val parsed0 = InspectArgsParser.get(file(".").getAbsoluteFile.toPath).parsed
val parsed = InspectArgs.from(parsed0.collect { case x: InspectArg.Wart =>
x
})
Def.taskDyn {
val errResult = compileWartFromSources(parsed(Type.Err)).value
val warnResult = compileWartFromSources(parsed(Type.Warn)).value
createInspectTask(
x = x,
warningWartNames = parsed(Type.Warn).warts ++ warnResult.wartNames,
errorWartNames = parsed(Type.Err).warts ++ errResult.wartNames,
jarFiles = errResult.jarBinary.toSeq ++ warnResult.jarBinary.toSeq,
)
}
}.evaluated,
x / wartremoverInspect := Def.taskDyn {
createInspectTask(
x = x,
warningWartNames = (x / wartremoverInspect / wartremoverWarnings).value,
errorWartNames = (x / wartremoverInspect / wartremoverErrors).value,
jarFiles = Nil,
)
}.value
)
private final case class CompileResult(jarBinary: Option[Seq[Byte]], wartNames: Seq[Wart])
private object CompileResult {
val empty: CompileResult = CompileResult(None, Nil)
}
private[this] def compileWartFromSources(inspectArg: InspectArgs): Def.Initialize[Task[CompileResult]] = {
Def.taskDyn {
val log = streams.value.log
val wartremoverJars = Def.taskDyn {
val wartremoverCross = wartremoverCrossVersion.value
getJarFiles(
"org.wartremover" %% "wartremover" % Wart.PluginVersion cross wartremoverCross
)
}.value
if (inspectArg.sources.nonEmpty) {
val bytes: Seq[Byte] = getJar(inspectArg.sources.toSet).value
IO.withTemporaryDirectory { tmpDir =>
val compiledJar = tmpDir / "wartremover" / "warts.jar"
IO.write(compiledJar, bytes.toArray)
log.debug(s"compiled jar = $compiledJar")
val classes = getAllClassNamesInJar(compiledJar)
if (classes.isEmpty) {
log.error("not found compiled classes")
Def.task(CompileResult.empty)
} else {
log.info(s"compiled classes = ${classes.mkString(" ")}")
val xs = Using.resource(
new URLClassLoader(
(compiledJar.toURI.toURL +: wartremoverJars.map(_.toURI.toURL)).toArray
)
) { loader =>
classes.filter { className =>
val clazz = Class.forName(className, false, loader)
val traverserName = "org.wartremover.WartTraverser"
@tailrec
def loop(c: Class[?]): Boolean = {
if (c == null) {
false
} else if (c.getName == traverserName) {
true
} else {
loop(c.getSuperclass)
}
}
if (Modifier.isAbstract(clazz.getModifiers)) {
false
} else {
loop(clazz)
}
}.map { s =>
if (s.endsWith("$")) s.dropRight(1) else s
}
}
Def.task(
CompileResult(jarBinary = Some(bytes), wartNames = xs.map(Wart.custom))
)
}
}
} else {
Def.task(
CompileResult.empty
)
}
}
}
private[wartremover] def getAllClassNamesInJar(jar: File): List[String] = {
val suffix = ".class"
Using.resource(new ZipInputStream(new FileInputStream(jar))) { zip =>
Iterator
.continually(
zip.getNextEntry
)
.takeWhile(_ != null)
.filter(e => !e.isDirectory && e.getName.endsWith(suffix))
.map(
_.getName.replace('/', '.').dropRight(suffix.length)
)
.toList
}
}
private[this] case class WartCacheKey(scalaV: String, files: Set[String])
private[this] val wartRunCache: TrieMap[WartCacheKey, Future[Seq[Byte]]] = TrieMap.empty
private[this] def getJar(files: Set[String]): Def.Initialize[Task[Seq[Byte]]] = Def.task {
val key = WartCacheKey(
scalaV = (wartremoverTask / scalaVersion).value,
files = files
)
val forkOps = (wartremoverTask / forkOptions).value
val launcher = sbtLauncher(wartremoverTask).value
val log = state.value.log
val res = wartRunCache.getOrElseUpdate(
key,
Future {
val buildSbt =
s"""
|logLevel := Level.Warn
|scalaVersion := "${key.scalaV}"
|crossPaths := false
|libraryDependencies := Seq(
| "org.wartremover" %% "wartremover" % "${Wart.PluginVersion}"
|)
|""".stripMargin
IO.withTemporaryDirectory { dir =>
IO.write(dir / "build.sbt", buildSbt.getBytes(StandardCharsets.UTF_8))
key.files.toSeq.sorted.zipWithIndex.foreach { case (src, index) =>
IO.write(dir / s"${index}.scala", src.getBytes(StandardCharsets.UTF_8))
}
log.info(s"compile ${key.files.size} files")
val exitCode = Fork.java.apply(
forkOps.withWorkingDirectory(dir),
Seq(
"-jar",
launcher.getCanonicalPath,
packageBin.key.label
)
)
assert(exitCode == 0, s"exit code = $exitCode")
log.info(s"compiled ${key.files.size} files")
val Seq(compiledJar) = (dir / "target").listFiles(f => f.isFile && f.getName.endsWith(".jar")).toList
IO.readBytes(compiledJar).toSeq
}
}(ExecutionContext.global)
)
Await.result(res, 2.minutes)
}
private[this] def createInspectTask(
x: Configuration,
errorWartNames: Seq[Wart],
warningWartNames: Seq[Wart],
jarFiles: Seq[Seq[Byte]],
): Def.Initialize[Task[InspectResult]] = Def.taskDyn {
val log = streams.value.log
val myProject = thisProjectRef.value
val thisTaskName = s"${myProject.project}/${x.id}/${wartremoverInspect.key.label}"
def skipLog(reason: String) = {
log.info(s"skip ${thisTaskName} because ${reason}")
InspectResult.empty
}
if (scalaBinaryVersion.value == "3") {
if (errorWartNames.isEmpty && warningWartNames.isEmpty) {
Def.task(skipLog("warts is empty"))
} else {
// avoid taskIf
// https://github.com/sbt/sbt/issues/6862
Def.taskDyn {
if ((x / tastyFiles).value.isEmpty) {
Def.task(skipLog(s"${tastyFiles.key.label} is empty"))
} else {
Def.task {
val dependenciesClasspath = (x / dependencyClasspath).value
val logStr = {
def names(xs: Seq[Wart]): List[String] = {
xs.map(_.clazz)
.distinct
.groupBy(a => a.split('.').lastOption.getOrElse(a))
.flatMap {
case (k, v) if v.size == 1 => k :: Nil
case (_, v) => v
}
.toList
.sorted
}
List(
if (errorWartNames.nonEmpty) {
names(errorWartNames).mkString("errorWarts = [", ", ", "].")
} else {
""
},
if (warningWartNames.nonEmpty) {
names(warningWartNames).mkString("warningWarts = [", ", ", "]")
} else {
""
}
).mkString(" ")
}
log.info(s"running ${thisTaskName}. ${logStr}")
val param = org.wartremover.InspectParam(
tastyFiles = (x / tastyFiles).value.map(_.getAbsolutePath).toList,
dependenciesClasspath = dependenciesClasspath.map(_.data.getAbsolutePath).toList,
wartClasspath = {
val filePrefix = "file:"
(x / wartremoverClasspaths).value.map {
case a if a.startsWith(filePrefix) =>
file(a.drop(filePrefix.length)).getCanonicalFile.toURI.toURL
case a =>
new URI(a).toURL
}.map(_.toString)
}.toList,
errorWarts = errorWartNames.map(_.clazz).toList,
warningWarts = warningWartNames.map(_.clazz).toList,
exclude = wartremoverExcluded.value.distinct.flatMap { c =>
val base = (LocalRootProject / baseDirectory).value
IO.relativize(base, c)
}.toList,
failIfWartLoadError = (x / wartremoverFailIfWartLoadError).value,
outputStandardReporter = (x / wartremoverInspectOutputStandardReporter).value
)
val launcher = sbtLauncher(wartremoverInspect).value
val resultJson = runInspector(
projectName = thisTaskName,
base = (LocalRootProject / baseDirectory).value,
param = param,
scalaV = wartremoverInspectScalaVersion.value,
launcher = launcher,
(x / sources).value,
forkOptions = (wartremoverInspect / forkOptions).value,
jarFiles = jarFiles,
extraSettings = wartremoverInspectSettings.value,
).fold(e => sys.error(s"${thisTaskName} failed ${e}"), identity)
val result = {
val r = resultJson.decodeFromJsonString[InspectResult]
new InspectResult(errors = r.errors, warnings = r.warnings, stderr = r.stderr) {
override def toString: String = resultJson
}
}
(x / wartremoverInspectOutputFile).?.value.flatten.foreach { outFile =>
log.info(s"[${thisProjectRef.value.project}] write result to ${outFile}")
IO.write(outFile, resultJson)
}
if (result.errors.nonEmpty && (x / wartremoverInspectFailOnErrors).value) {
sys.error(s"[${thisProjectRef.value.project}] wart error found")
} else {
log.info(s"finished ${thisTaskName}. found ${result.warnings.size} warnings")
result
}
}.tag(WartremoverTag)
}
}
}
} else {
Def.task(
skipLog(s"scalaVersion is ${scalaVersion.value}. not Scala 3")
)
}
}
private[this] def getJarFiles(module: ModuleID): Def.Initialize[Task[Seq[File]]] = Def.task {
dependencyResolution.value
.retrieve(
dependencyId = module,
scalaModuleInfo = scalaModuleInfo.value,
retrieveDirectory = csrCacheDirectory.value,
log = streams.value.log
)
.left
.map(e => throw e.resolveException)
.merge
.distinct
}
private[this] def sbtLauncher(k: HasSlashKey): Def.Initialize[Task[File]] = Def.taskDyn {
val v = (k / sbtVersion).value
Def.task {
val Seq(launcher) = getJarFiles("org.scala-sbt" % "sbt-launch" % v).value
launcher
}
}
override lazy val projectSettings: Seq[Def.Setting[_]] = Def.settings(
libraryDependencies ++= {
Seq(
compilerPlugin(
"org.wartremover" %% "wartremover" % Wart.PluginVersion cross wartremoverCrossVersion.value
)
)
},
wartremoverFailIfWartLoadError := false,
wartremoverInspectFailOnErrors := true,
wartremoverInspectOutputStandardReporter := true,
Seq(Compile, Test).flatMap(inspectTask),
scalacOptionSetting(scalacOptions),
scalacOptionSetting(Compile / scalacOptions),
scalacOptionSetting(Test / scalacOptions),
scalacOptions ++= {
// use relative path
// https://github.com/sbt/sbt/issues/6027
wartremoverExcluded.value.distinct.map { c =>
val base = (LocalRootProject / baseDirectory).value
val x = base.toPath.relativize(c.toPath)
s"-P:wartremover:excluded:$x"
}
},
wartremoverPluginJarsDir := {
if (VersionNumber(sbtVersion.value).matchesSemVer(SemanticSelector(">=1.4.0"))) {
Some((LocalRootProject / crossTarget).value / "compiler_plugins")
} else {
None
}
},
inScope(Scope.ThisScope)(
Seq(
wartremoverClasspaths ++= {
val d = dependencyResolution.value
val jars = wartremoverDependencies.value.flatMap { m =>
val moduleId = CrossVersion(
cross = m.crossVersion,
fullVersion = scalaVersion.value,
binaryVersion = scalaBinaryVersion.value
) match {
case Some(f) =>
m.withName(f(Project.normalizeModuleID(m.name)))
case None =>
m
}
d.retrieve(
dependencyId = moduleId,
scalaModuleInfo = scalaModuleInfo.value,
retrieveDirectory = csrCacheDirectory.value,
log = streams.value.log
).left
.map(e => throw e.resolveException)
.merge
}.distinct
jars.map { a =>
copyToCompilerPluginJarsDir(
src = a,
jarDir = wartremoverPluginJarsDir.value,
base = (LocalRootProject / baseDirectory).value,
log = streams.value.log
).map("file:" + _).getOrElse(a.toURI.toString)
}
},
derive(
scalacOptions ++= {
if (wartremoverFailIfWartLoadError.value) {
Seq(s"-P:wartremover:on-wart-load-error:failure")
} else {
Nil
}
}
),
derive(
scalacOptions ++= {
wartremoverErrors.value.distinct map (w => s"-P:wartremover:traverser:${w.clazz}")
}
),
derive(
scalacOptions ++= {
wartremoverWarnings.value.distinct filterNot (wartremoverErrors.value contains _) map (w =>
s"-P:wartremover:only-warn-traverser:${w.clazz}"
)
}
),
derive(
scalacOptions ++= {
wartremoverClasspaths.value.distinct map (cp => s"-P:wartremover:cp:$cp")
}
)
)
)
)
private[wartremover] def derive[T](s: Setting[T]): Setting[T] =
Def derive s
}