Regression in 1.2.0: Missing dependency

[ilovezfs]

Bisecting showed that the regression is due to f92d8da.

bash-3.2$ /usr/local/Cellar/wartremover/1.2.0/bin/wartremover -traverser org.wartremover.warts.Unsafe foo 2>&1
error: error while loading Object, Missing dependency 'object scala in compiler mirror', required by /Library/Java/JavaVirtualMachines/jdk1.8.0_92.jdk/Contents/Home/jre/lib/rt.jar(java/lang/Object.class)
Exception in thread "main" scala.reflect.internal.MissingRequirementError: object scala in compiler mirror not found.
	at scala.reflect.internal.MissingRequirementError$.signal(MissingRequirementError.scala:17)
	at scala.reflect.internal.MissingRequirementError$.notFound(MissingRequirementError.scala:18)
	at scala.reflect.internal.Mirrors$RootsBase.getModuleOrClass(Mirrors.scala:53)
	at scala.reflect.internal.Mirrors$RootsBase.getModuleOrClass(Mirrors.scala:66)
	at scala.reflect.internal.Mirrors$RootsBase.getPackage(Mirrors.scala:173)
	at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackage$lzycompute(Definitions.scala:161)
	at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackage(Definitions.scala:161)
	at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackageClass$lzycompute(Definitions.scala:162)
	at scala.reflect.internal.Definitions$DefinitionsClass.ScalaPackageClass(Definitions.scala:162)
	at scala.reflect.internal.Definitions$DefinitionsClass.init(Definitions.scala:1395)
	at scala.tools.nsc.Global$Run.<init>(Global.scala:1215)
	at org.wartremover.Main$.compile(Main.scala:33)
	at org.wartremover.Main$.main(Main.scala:51)
	at org.wartremover.Main.main(Main.scala)

This occurs during the Homebrew test block, after wartremover is installed.

The test does the following

  test do
    (testpath/"foo").write <<-EOS.undent
      object Foo {
        def foo() {
          var msg = "Hello World"
          println(msg)
        }
      }
    EOS
    cmd = "#{bin}/wartremover -traverser org.wartremover.warts.Unsafe foo 2>&1"
    assert_match "var is disabled", shell_output(cmd, 1)
  end

This works fine with 1.1.1 but crashes as above with 1.2.0.

If I revert f92d8da, the problem goes away.

[ilovezfs]

Build log is here: https://bot.brew.sh/job/Homebrew%20Core/10906/version=any_sierra/consoleText

[ClaireNeveu]

Resolved by e914d91. This will be in the 1.2.1 release.

[ilovezfs]

@ChrisNeveu thanks!