Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Install - error #32

Open
dnyt84 opened this issue Oct 19, 2020 · 1 comment · May be fixed by #34
Open

New Install - error #32

dnyt84 opened this issue Oct 19, 2020 · 1 comment · May be fixed by #34

Comments

@dnyt84
Copy link

dnyt84 commented Oct 19, 2020

Hello,

i just installed janitor on Centos 7 with Python 3.6.

the command "flask db init" would fail.
It complaint about ma.ModelSchema in app/models.py

Doing a little research it appears that this command will be deprecated.

https://flask-marshmallow.readthedocs.io/en/latest/changelog.html

They suggest to change this to ma.SQLAlchemyAutoSchema.
i modified my app/models.py and it worked.

Thank you,

Daniel
@wasabi222 wasabi222 linked a pull request Oct 21, 2020 that will close this issue
Open
@wasabi222
Copy link
Owner

Thanks for this, I really should have pinned versions for this. I opened up a PR that will pin this - I still need to pin marshmallow versions as well - and then I'll look to get this fixed with a more recent version of flask-marshmallow so it doesn't break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pin flask_marshmallow to prevent breaking changes wasabi222/janitor
2 participants
@wasabi222 @dnyt84